Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature scaffolding - added funcs for env var handling, doc updates and resource pretty print implementation #19

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

ShocOne
Copy link
Contributor

@ShocOne ShocOne commented Jul 24, 2024

Change

Feel free to remove this sample text

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

github-actions bot and others added 7 commits July 24, 2024 13:02
…nt variable usage

The code changes in `variables.go` and `provider.go` update the `GetEnvOrDefault` and `GetEnvOrDefaultBool` functions to log the usage of environment variables. This provides visibility into which environment variables are being used and their values, aiding in debugging and troubleshooting.

Note: This commit message follows the established convention of using a prefix to indicate the type of change (`feat` for a new feature) and provides a clear and concise description of the changes made.
The code changes in provider.go remove the commented out code for GUID validation in the Schema function. This code was previously disabled and is no longer needed, so it has been removed to improve code readability and maintainability.

Note: This commit message follows the established convention of using a prefix to indicate the type of change (`refactor` for code refactoring) and provides a clear and concise description of the changes made.
The code changes in `object.go` refactor the construction of the assignment filter resource. The `constructResource` function now marshals the request body to JSON and logs the constructed assignment filter resource. This improves code readability and provides better visibility into the constructed resource.

Note: This commit message follows the established convention of using a prefix to indicate the type of change (`refactor` for code refactoring) and provides a clear and concise description of the changes made.
The code changes in `client.go` update the documentation for the Microsoft Graph clients (`StableClient` and `BetaClient`) to emphasize the stability and reliability of the v1.0 endpoint and the experimental nature of the beta endpoint. The updated documentation provides developers with clear guidance on which endpoint to use for different scenarios, ensuring better stability, reliability, and user experience.

Note: This commit message follows the established convention of using a prefix to indicate the type of change (`refactor` for code refactoring) and provides a clear and concise description of the changes made.
@ShocOne ShocOne merged commit fab4be7 into main Jul 24, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant