Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added retry logic honoring graph throttling guardrails #232

Merged
merged 13 commits into from
Dec 1, 2024

Conversation

ShocOne
Copy link
Contributor

@ShocOne ShocOne commented Dec 1, 2024

Change

Feel free to remove this sample text

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor of existing code

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

… paths; remove commented-out code for improved readability and maintainability. Update custom PUT request configuration to ensure correct API versioning.
… implement PreserveSecretSettings function for recursive handling of secret settings in JSON structures. Enhance error logging for better debugging during normalization processes.
…plement ByIDRequestUrlTemplate and PutRequestByResourceId functions for improved URL construction and PUT request management. Update existing CRUD operations to utilize new configurations, enhancing code organization and maintainability.
…kage; validate various endpoint configurations and expected URL outputs to ensure correct URL construction.
…for clarity in GetRequestByResourceId, PostRequest, and PutRequestByResourceId. Introduce PutResponse struct for better response management.
…r for GET request execution and response reading failures to improve clarity and maintainability.
…anagement by directly appending diagnostics and updating state from Read operation. Enhance MapRemoteSettingsStateToTerraform function to normalize settings JSON and preserve secret values, improving error handling and logging.
…Operation and RetryableOperation functions to manage throttling and implement exponential backoff with jitter. Update state mapping in settings catalog to remove unused fields, improving clarity and maintainability.
…dTimeout for timeout handling; improve code clarity with added comments.
…includes functions for pagination, policy retrieval, and deletion with user confirmation.
@ShocOne ShocOne merged commit 797d783 into main Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant