Fix phpstan errors

deployphp · Oct 27, 2024 · 85b4d8d · 85b4d8d
1 parent 9abe633
commit 85b4d8d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 16 deletions.
diff --git a/src/Collection/Collection.php b/src/Collection/Collection.php
@@ -26,9 +26,8 @@ public function get(string $name): mixed
     {
         if ($this->has($name)) {
             return $this->values[$name];
-        } else {
-            $this->throwNotFound($name);
         }
+        throw $this->notFound($name);
     }
 
     public function has(string $name): bool
@@ -45,9 +44,8 @@ public function remove(string $name): void
     {
         if ($this->has($name)) {
             unset($this->values[$name]);
-        } else {
-            $this->throwNotFound($name);
         }
+        throw $this->notFound($name);
     }
 
     public function count(): int
@@ -77,8 +75,8 @@ public function getIterator()
         return new \ArrayIterator($this->values);
     }
 
-    protected function throwNotFound(string $name): void
+    protected function notFound(string $name): \InvalidArgumentException
     {
-        throw new \InvalidArgumentException("Element \"$name\" not found in collection.");
+        return new \InvalidArgumentException("Element \"$name\" not found in collection.");
     }
 }
diff --git a/src/Host/HostCollection.php b/src/Host/HostCollection.php
@@ -18,8 +18,8 @@
  */
 class HostCollection extends Collection
 {
-    protected function throwNotFound(string $name): void
+    protected function notFound(string $name): \InvalidArgumentException
     {
-        throw new \InvalidArgumentException("Host \"$name\" not found.");
+        return new \InvalidArgumentException("Host \"$name\" not found.");
     }
 }
diff --git a/src/Ssh/SshClient.php b/src/Ssh/SshClient.php
@@ -104,10 +104,4 @@ public function run(Host $host, string $command, array $config = []): string
 
         return $output;
     }
-
-    private function parseExitStatus(Process $process): int
-    {
-        preg_match('/\[exit_code:(\d*)]/', $process->getOutput(), $match);
-        return (int) ($match[1] ?? -1);
-    }
 }
diff --git a/src/Task/TaskCollection.php b/src/Task/TaskCollection.php
@@ -18,9 +18,9 @@
  */
 class TaskCollection extends Collection
 {
-    protected function throwNotFound(string $name): void
+    protected function notFound(string $name): \InvalidArgumentException
     {
-        throw new \InvalidArgumentException("Task `$name` not found.");
+        return new \InvalidArgumentException("Task `$name` not found.");
     }
 
     public function add(Task $task): void