Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-200] API 응답 규격 수정 #69

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

nahyeon99
Copy link
Member

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 웹 팀과 논의한대로, 일부 응답 규격을 수정하였습니다.
      1. 진행중인 릴레이질문 및 답변 조회 api : 질문유형(단일/다중) 응답 추가 및 질문유형 필드 추가
      1. 질문 및 대상자 랜덤 선택 api : excludeQuestionId - NOT_REQUIRED 표기
      1. engagementRate 반올림하여 응답
  • DateTimeFormatter 정적 팩토리 클래스 → 어노테이션 수정 (timestamp 반환 규격 변경에 대한 대응은 이후 PR로 진행)

🔗 ISSUE 링크

@nahyeon99 nahyeon99 self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit af9742c.

@kkjsw17
Copy link
Collaborator

kkjsw17 commented Aug 1, 2024

확인했습니다! 고생하셨습니다 👍

@nahyeon99 nahyeon99 merged commit 8494ee1 into develop Aug 1, 2024
2 checks passed
@nahyeon99 nahyeon99 deleted the feature/SAMBAD-200-refactor_responses branch August 1, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants