Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-195] redirect url 판단 시, userId가 잘못된 값으로 사용되는 이슈 수정 #71

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

kkjsw17
Copy link
Collaborator

@kkjsw17 kkjsw17 commented Aug 1, 2024

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • SecurityContextHolder.getContext().getAuthentication().getName() 호출 시, userId가 아닌 externalId가 반환됩니다.
  • LoginResultuserId를 추가하는 방식으로 수정합니다.

🔗 ISSUE 링크

@kkjsw17 kkjsw17 self-assigned this Aug 1, 2024
Copy link
Member

@nahyeon99 nahyeon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 실패하는 것만 고치면 될 것 같습니다!

@kkjsw17
Copy link
Collaborator Author

kkjsw17 commented Aug 2, 2024

테스트 실패하는 것만 고치면 될 것 같습니다!

이거 github rate limit 에러로 액션 실행이 안되었어요. 테스트 따로 추가한건 없슴당 ㅋㅋㅋㅋ

@kkjsw17 kkjsw17 merged commit a4d6ff6 into develop Aug 2, 2024
1 of 2 checks passed
@kkjsw17 kkjsw17 deleted the fix/SAMBAD-195-redirect_url_bug_fix branch August 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants