Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인앱 브라우저에서 외부 브라우저로 열릴 때, 인앱 브라우저 라우팅 #452

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

hyesungoh
Copy link
Member

@hyesungoh hyesungoh commented Nov 5, 2023

🤔 해결하려는 문제가 무엇인가요?

외부 브라우저에서 동작을 마치고 인앱 브라우저로 돌아왔을 때 혼란을 느낄 수 있어요

🎉 변경 사항

인앱 브라우저(카카오톡 등)에서 외부 브라우저로 열릴 때

루트로 라우팅해요

📚 참고

Note
qa 브랜치에서 동작 확인 했어요 ~

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c5b1fb) 89.34% compared to head (6590c7a) 89.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          44       44           
  Lines         338      338           
  Branches       61       61           
=======================================
  Hits          302      302           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 5, 2023

Bundle Sizes

Compared against 0c5b1fb

Route: No significant changes found

Dynamic import: No significant changes found

@hyesungoh hyesungoh changed the title WIP 인앱 브라우저에서 외부 브라우저로 열릴 때, 인앱 브라우저 라우팅 Nov 5, 2023
@hyesungoh hyesungoh self-assigned this Nov 5, 2023
@hyesungoh hyesungoh marked this pull request as ready for review November 5, 2023 04:30
@hyesungoh hyesungoh added the feat New feature or request label Nov 5, 2023
@hyesungoh hyesungoh merged commit 403055c into main Nov 5, 2023
11 of 12 checks passed
@hyesungoh hyesungoh deleted the feature/move-to-main-when-open-external branch November 5, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

인앱 브라우저에서 외부 브라우저로 열릴 때, 기존 인앱 브라우저 라우팅
2 participants