결과페이지 첫 방문시에만 Tooltip 보이도록 수정 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoleee
requested review from
hyesungoh,
oyeon-kwon and
sumi-0011
as code owners
Bundle SizesCompared against 59b9fec Route: No significant changes found Dynamic import: No significant changes found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 44 44
Lines 339 339
Branches 62 62
=======================================
Hits 303 303
Misses 36 36
☔ View full report in Codecov by Sentry. |
hyesungoh
approved these changes
Nov 6, 2023
| @@ -3,4 +3,5 @@ export const LOCAL_STORAGE_KEY = { | |||
| reviewShortQuestionMessages: 'nlasq', | |||
| surveyCustomQuestions: 'nlascq', | |||
| surveyCreateSurveyRequest: 'nlascsr', | |||
| resultRevisit: 'nlarv', | |||
src/pages/result/SurveyIdLoaded.tsx
Outdated
| @@ -44,6 +47,8 @@ const PILL_COLORS: Color[] = ['bluegreen', 'pink', 'skyblue', 'yellowgreen', 'pu | |||
|
|
|||
| const SurveyIdLoaded = ({ surveyId }: Props) => { | |||
| const { fireToast } = useToast(); | |||
| const [isRevisit, setIsRevisit] = useLocalStorage<boolean>(`${LOCAL_STORAGE_KEY.resultRevisit}`, false); | |||
There was a problem hiding this comment.
Suggested change
| const [isRevisit, setIsRevisit] = useLocalStorage<boolean>(`${LOCAL_STORAGE_KEY.resultRevisit}`, false); | |
| const [isRevisit, setIsRevisit] = useLocalStorage<boolean>(LOCAL_STORAGE_KEY.resultRevisit, false); |
상수가 문자열이라 이렇게 써도 되지 않을까욘?? 🤔
There was a problem hiding this comment.
오옹 이렇게 쓰면 어떤 변수가 들어와도 문자열임을 보장할 수 있어서 권장하는 방법인가요?! 궁금 @hyesungoh
There was a problem hiding this comment.
`${LOCAL_STORAGE_KEY.resultRevisit}`산됴우님이 작성하신 방법은 말씀하신 것처럼 어떤 값이 들어와도 문자열임을 보장할 수 있는 방법인 거 같아용
근데 제가 말씀드린
LOCAL_STORAGE_KEY.resultRevisit요건 저장된 값이 문자열이니, 그냥 사용해도 되지 않을까 ~~~ 하는 생각입니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
매번 툴팁이 보여서 불편하다는 유저 피드백 반영
🎉 변경 사항
로컬스토리지에
isRevisit을 추가하고 unmount 시점에 true로 변경해줍니다.true이면 툴팁을 렌더링하지 않습니다.
더 좋은 방법이 있다면 제보 바랍니다~~
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
📚 참고