feat: 설문이 있을 때 핸들링 #491
Merged
feat: 설문이 있을 때 핸들링 #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
requested review from
oyeon-kwon,
sjoleee and
sumi-0011
as code owners
sumi-0011
reviewed
Mar 20, 2024
Comment on lines
+21
to
+25
| function replaceWhenHasSurvey() { | ||
| if (isLoading) return; | ||
| if (hasSurvey) router.replace('/result'); | ||
| }, | ||
| [hasSurvey, isLoading, router], |
There was a problem hiding this comment.
�useEffect 안의 함수에 이름을 지정해둔 이유가 있을까요? 👀
There was a problem hiding this comment.
오호호 이건 모던 리액트 딥다이브에 나온 내용이기도 한데요
제 생각과 함께 설명드리자면
이펙트에 기명함수를 쓰면 좋은 점은
- 이펙트의 역할 명시 (그냥 이펙트만 있으면 해당 이펙트의 역할을 코드를 읽어야 알 수 있음)
- 메모리 디버깅 시 이점 (익명 함수는 찾기가 어려워 어느 함수인지 알지못함)
요런 이유가 있습니다 ~
그래서 간단한 이펙트가 아니면 전 ㅁ쓰려고 하곤해용
* chore: 결과 베이스 이미지 * feat: mobile header props 뚫기 * feat: 결과 베이스
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
/survey/base가 보이면 안됨🌄 스크린샷
2024-03-20.10.28.08.mov