Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-420 feat: sentry 도입 #215

Merged
merged 3 commits into from
Oct 16, 2023
Merged

DEP-420 feat: sentry 도입 #215

merged 3 commits into from
Oct 16, 2023

Conversation

kimhyeing
Copy link
Contributor

@kimhyeing kimhyeing commented Sep 3, 2023

💁‍♂️ 변경 내용

AS-IS

  • 에러 발생 시 토스트로만 유저에게 알려주었고, 개발자는 crash가 아닌 애러는 리포트받을 수 없었습니다.

TO-BE

  • relaese/degub 별로 에러 발생 시 sentry를 통해 해당 에러를 추적할 수 있습니다.
  • 인터넷 연결 오류 시엔 sentry로 에러를 보고하지 않습니다.

📢 전달사항

  • 인터넷 연결 오류 시엔 sentry로 에러를 안보내게 하려고 했는데, 이 로직을 하나의 함수로 만들어서 하려니까 sentry에 리포트 되는 위치가 A activity 가 아닌 해당 함수가 선언된.. 가령 SentrySdk class 등으로 위치가 표시되어서 .. 다 일일히 작성했는데 더 좋은 의견 있으실까요??

Sentry three-days-dev : https://depromeet-d5233f6c0.sentry.io/issues/?referrer=sidebar

디프만 공용계정으로 로그인하시면 됩니다!

local property 설정하셔야 하는데 이건 따로 올려두겠습니다!

@kimhyeing kimhyeing self-assigned this Sep 3, 2023
@kimhyeing kimhyeing requested a review from a team as a code owner September 3, 2023 18:31
@kimhyeing kimhyeing merged commit 8890152 into develop Oct 16, 2023
1 of 2 checks passed
@kimhyeing kimhyeing deleted the feature/DEP-420 branch October 16, 2023 02:22
@kimhyeing kimhyeing restored the feature/DEP-420 branch October 16, 2023 08:34
@kimhyeing kimhyeing deleted the feature/DEP-420 branch October 16, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant