Skip to content

Commit

Permalink
chore: bump jsdom from 23.2.0 to 24.0.0 (#4321)
Browse files Browse the repository at this point in the history
Bumps [jsdom](https://github.com/jsdom/jsdom) from 23.2.0 to 24.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/jsdom/jsdom/releases">jsdom's
releases</a>.</em></p>
<blockquote>
<h2>Version 24.0.0</h2>
<p>This release reverts our selector engine back to <a
href="https://www.npmjs.com/nwsapi"><code>nwsapi</code></a>. As
discussed in <a
href="https://redirect.github.com/jsdom/jsdom/issues/3659">#3659</a>,
the performance regressions from <a
href="https://www.npmjs.com/package/@asamuzakjp/dom-selector"><code>@asamuzakjp/dom-selector</code></a>
turned out to be higher than anticipated. In the future, we can revisit
<code>@asamuzakjp/dom-selector</code> after it reaches
<code>nwsapi</code>'s performance on the <a
href="https://redirect.github.com/jsdom/jsdom/issues/3659#issuecomment-1890852609">two
real-world benchmarks provided by the community</a>.</p>
<p>Since reverting to <code>nwsapi</code> causes several functionality
regressions, e.g. removing <code>:has()</code> support, we've decided to
make this a major version.</p>
<p>Additionally:</p>
<ul>
<li>Small fixes to edge-case behavior of the following properties:
<code>input.maxLength</code>, <code>input.minLength</code>,
<code>input.size</code>, <code>progress.max</code>,
<code>tableCell.colSpan</code>, <code>tableCell.rowSpan</code>,
<code>tableCol.span</code>, <code>textArea.cols</code>,
<code>textArea.maxLength</code>, <code>textArea.minLength</code>,
<code>textArea.rows</code>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/jsdom/jsdom/blob/main/Changelog.md">jsdom's
changelog</a>.</em></p>
<blockquote>
<h2>24.0.0</h2>
<p>This release reverts our selector engine back to <a
href="https://www.npmjs.com/nwsapi"><code>nwsapi</code></a>. As
discussed in <a
href="https://redirect.github.com/jsdom/jsdom/issues/3659">#3659</a>,
the performance regressions from <a
href="https://www.npmjs.com/package/@asamuzakjp/dom-selector"><code>@asamuzakjp/dom-selector</code></a>
turned out to be higher than anticipated. In the future, we can revisit
<code>@asamuzakjp/dom-selector</code> after it reaches
<code>nwsapi</code>'s performance on the <a
href="https://redirect.github.com/jsdom/jsdom/issues/3659#issuecomment-1890852609">two
real-world benchmarks provided by the community</a>.</p>
<p>Since reverting to <code>nwsapi</code> causes several functionality
regressions, e.g. removing <code>:has()</code> support, we've decided to
make this a major version.</p>
<p>Additionally:</p>
<ul>
<li>Small fixes to edge-case behavior of the following properties:
<code>input.maxLength</code>, <code>input.minLength</code>,
<code>input.size</code>, <code>progress.max</code>,
<code>tableCell.colSpan</code>, <code>tableCell.rowSpan</code>,
<code>tableCol.span</code>, <code>textArea.cols</code>,
<code>textArea.maxLength</code>, <code>textArea.minLength</code>,
<code>textArea.rows</code>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/jsdom/jsdom/commit/2f8a7302a43fff92f244d5f3426367a8eb2b8896"><code>2f8a730</code></a>
Version 24.0.0</li>
<li><a
href="https://github.com/jsdom/jsdom/commit/db0a4dc4f9f9077f83be20daf9a34f255bd1264b"><code>db0a4dc</code></a>
Implement the remaining types of numeric reflection</li>
<li><a
href="https://github.com/jsdom/jsdom/commit/c1d7005f1dfa3312e831b000464f49966b5edffe"><code>c1d7005</code></a>
Implement full long reflection</li>
<li><a
href="https://github.com/jsdom/jsdom/commit/ac815fff2339b0175a1eca6ee6be3298b63035a8"><code>ac815ff</code></a>
Revert back to nwsapi</li>
<li><a
href="https://github.com/jsdom/jsdom/commit/5b1a49e7d56bb58fec980ce7caadbf26775e95b4"><code>5b1a49e</code></a>
Fix changelog link to dom-selector</li>
<li>See full diff in <a
href="https://github.com/jsdom/jsdom/compare/23.2.0...24.0.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jsdom&package-manager=npm_and_yarn&previous-version=23.2.0&new-version=24.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
dependabot[bot] authored Feb 1, 2024
1 parent 12ded32 commit a2f6082
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 116 deletions.
137 changes: 22 additions & 115 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
"inquirer": "^8.2.5",
"jquery": "^3.6.3",
"jsdoc": "^4.0.2",
"jsdom": "^23.0.1",
"jsdom": "^24.0.0",
"karma": "^6.4.1",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^3.1.1",
Expand Down

0 comments on commit a2f6082

Please sign in to comment.