fix(aria-valid-attr-value): more thorough test coverage

- messageKey added to unit test
- integration test

Refs: #4363

test/checks/aria/valid-attr-value.js

@@ -117,6 +117,10 @@ describe('aria-valid-attr-value', function () {
     assert.isUndefined(
       validAttrValueCheck.call(checkContext, null, null, vNode)
     );
+    assert.deepEqual(checkContext._data, {
+      messageKey: 'controlsWithinPopup',
+      needsReview: 'aria-controls="test"'
+    });
   });
 
   it('should pass on aria-owns and aria-expanded=false when the element is not in the DOM', function () {

test/integration/rules/aria-valid-attr-value/aria-valid-attr-value.html

@@ -360,4 +360,7 @@ <h2>Possible False Positives</h2>
   <div role="checkbox" id="incomplete6" aria-checked>I'm not checked</div>
   <div role="textbox" id="incomplete7" aria-invalid="">I'm actually valid</div>
   <div role="textbox" id="incomplete8" aria-hidden>I'm not really gone</div>
+  <div id="incomplete9" aria-controls="stuff" aria-haspopup="true">
+    May have injected html to control dynamically later, who knows!
+  </div>
 </div>

test/integration/rules/aria-valid-attr-value/aria-valid-attr-value.json

@@ -236,6 +236,7 @@
     ["#incomplete5"],
     ["#incomplete6"],
     ["#incomplete7"],
-    ["#incomplete8"]
+    ["#incomplete8"],
+    ["#incomplete9"]
   ]
 }