chore: update ACT tests #4233
Merged
chore: update ACT tests #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Nov 2, 2023
| axeRules: ['avoid-inline-spacing'] | ||
| axeRules: ['avoid-inline-spacing'], | ||
| // See: https://github.com/dequelabs/axe-core/issues/4232 | ||
| skipTests: [ |
There was a problem hiding this comment.
Heads up, there's a problem in the testcases.json file. Due to a mistake all but these three test cases are missing for this rule. I'm working to have that fixed. I don't know if the fix of that is going to reveal new issues here. We'll see.
There was a problem hiding this comment.
Is there an issue open for the problem? Would hate for it to slip through the cracks.
There was a problem hiding this comment.
There is: w3c/wcag-act-rules#251
straker
approved these changes
Nov 3, 2023
| axeRules: ['avoid-inline-spacing'] | ||
| axeRules: ['avoid-inline-spacing'], | ||
| // See: https://github.com/dequelabs/axe-core/issues/4232 | ||
| skipTests: [ |
There was a problem hiding this comment.
Is there an issue open for the problem? Would hate for it to slip through the cracks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to the latest ACT tests (with some notes on things that are no longer consistent). This should prevent nightly from failing.