chore(test/rule-matches): var -> const & let #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
requested changes
Jun 11, 2024
| assert.isTrue(rule.matches(node, virtualNode)); | ||
| } | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe('aside should not match when scoped to a sectioning content element unless it has an accessible name', function () { |
There was a problem hiding this comment.
You seem to have accidentally reverted https://github.com/dequelabs/axe-core/pull/4469/files#diff-0ef6a2f04e39c405fcbf972fe657cad972110dc05e1a7d757d5a171e4a69140a
There was a problem hiding this comment.
oops, just tried to fix this by checking out the version from develop and making the updates again manually
WilcoFiers
approved these changes
Jun 17, 2024
WilcoFiers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
test/rule-matchesSmaller part of the full vision: #4444