Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump browser-driver-manager from 1.0.4 to 2.0.0 #4520

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2024

Bumps browser-driver-manager from 1.0.4 to 2.0.0.

Release notes

Sourced from browser-driver-manager's releases.

v2.0.0

Breaking Change

V1 use to detect the version of Chrome installed on the system and install the corresponding version of the chromedriver npm package. However this had problems as the chromedriver package wasn't always up-to-date with the latest version so when Chrome updated to the next version, the chromedriver package could lag behind and still cause out-of-sync issues. Additionally the chromedriver package didn't always have the latest versions of non-stable channels so asking for Chrome Canary wasn't always reliable.

V2 uses the newly released Chrome for Testing to manage Chrome. This enables both installing specific versions of Chrome and fixes the previous chromedriver package issue. V2 utilizes the puppeteer/browser script to manage the installation of Chrome and Chromedriver as it can handle downloading the binaries (and the multiple changes to the chromedriver download URL). This means that v2 no longer uses the chromedriver npm package to get chromedriver.

Once installed, a directory is created in your home directory called .browser-driver-manager. The directory will contain a .env file which will list the install path of both Chrome and Chromedriver under CHROME_TEST_PATH and CHROMEDRIVER_TEST_PATH respectively.

# ~/.browser-driver-manager/.env
CHROME_TEST_PATH="~/.browser-driver-manager/chrome/mac_arm-125.0.6422.141/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing"
CHROMEDRIVER_TEST_PATH="~/.browser-driver-manager/chromedriver/mac_arm-125.0.6422.141/chromedriver-mac-arm64/chromedriver"

This means in v2 you'll need to grab the Chromedriver path from the ~/.browser-driver-manager/.env file and not from the chromedriver npm package. Additionally, you'll need to grab the Chrome path pass the path to any browser driver, such as Webdriver.

Here's an example of grabbing the Chromedriver path in v1 and the change for v2.

// v1
const chromedriver = require('chromedriver');
console.log(chromedriver.path);
// v2
require('dotenv').config({ path: '.browser-driver-manager/.env' })
console.log(process.env.CHROMEDRIVER_TEST_PATH);

Commits
  • c3c8b57 2.0.0
  • 4f8a55d docs: add migration guide
  • 2e2ed52 feat: allow @ and = to specify version
  • 469d008 feat: use node and @​puppeteer/browsers to install and sync Chrome and ChromeD...
  • c610d9c docs: add keywords to package file (#8)
  • f6d5d73 Update package.json (#7)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [browser-driver-manager](https://github.com/straker/browser-driver-manager) from 1.0.4 to 2.0.0.
- [Release notes](https://github.com/straker/browser-driver-manager/releases)
- [Commits](straker/browser-driver-manager@v1.0.4...v2.0.0)

---
updated-dependencies:
- dependency-name: browser-driver-manager
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner July 1, 2024 12:23
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 1, 2024
@straker
Copy link
Contributor

straker commented Jul 9, 2024

We're not ready for this change just yet.

@straker straker closed this Jul 9, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 9, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/browser-driver-manager-2.0.0 branch July 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant