Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(object-is-loaded-matches): prevent test flakiness by allowing more time to load <object> data #4530

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jul 8, 2024

These test failures are happening because the test isn't allowing sufficient time for slower test scenarios (headed browsers in CI machines) to finish setting up test fixtures before testing against them.

I experimented with using load/error events on the fixtures instead of a flat time, but this didn't work reliably; in the case where the browser renders fallback content, it fires the error event before the fallback content is ready, at least in Chromium stable. I wanted to stick to a timebox for this so I settled for just increasing the time allotment instead.

Closes: #4529

@dbjorge dbjorge requested a review from a team as a code owner July 8, 2024 16:06
@dbjorge dbjorge merged commit deb2dcb into develop Jul 8, 2024
21 checks passed
@dbjorge dbjorge deleted the flakey-test branch July 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object-is-loaded-matches test flakiness in nightly CI builds
2 participants