Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v4.10.0 #4545

Merged
merged 46 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
7844c7c
chore: merge master into develop (#4448)
WilcoFiers May 6, 2024
ebb1b95
test: update `@axe-core/webdriverjs` package (#4442)
michael-siek May 6, 2024
3d36f97
build: lint-staged prettier before eslint (#4445)
gaiety-deque May 7, 2024
b523ace
style(lib/checks): var -> let and const codemod (#4451)
gaiety-deque May 7, 2024
00b9fba
test: rename generic test titles (#4453)
straker May 8, 2024
a32eb3a
style(lib/commons): var -> let and const codemod (#4455)
gaiety-deque May 10, 2024
79f0908
chore: bump chromedriver from 123.0.2 to 124.0.1 (#4439)
dependabot[bot] May 13, 2024
c9d4bc9
chore: bump stefanzweifel/git-auto-commit-action from 5.0.0 to 5.0.1 …
dependabot[bot] May 13, 2024
7509518
chore(i18n): update Japanese translation to reflect changes occurred …
ma10 May 15, 2024
a58e846
chore: Update locale de.json (#4461)
EvilKarter May 15, 2024
518b345
chore: bump the npm-low-risk group across 1 directory with 9 updates …
dependabot[bot] May 16, 2024
f584e8e
chore: upgrade to eslint9 (#4462)
michael-siek May 17, 2024
3f13aa1
fix(all-rules): fix flakey all-rules firefox test (#4467)
gaiety-deque May 20, 2024
9a22787
perf: memoize DqElement (#4452)
straker May 23, 2024
6699ee4
chore: ignore colorjs.io updates from dependabot (#4464)
straker May 23, 2024
d3db593
fix(build): limit locales to valid files when using the --all-lang op…
isner Jun 3, 2024
db4ec05
chore: ignore conventional-commits-parser >= 6 as esm (#4489)
straker Jun 4, 2024
879a366
chore: bump chromedriver from 124.0.1 to 125.0.1 (#4477)
dependabot[bot] Jun 4, 2024
ae320fa
chore: make cherry-pick script executable (#4490)
straker Jun 4, 2024
ed1c874
chore: bump the npm-low-risk group across 1 directory with 13 updates…
dependabot[bot] Jun 4, 2024
070bc01
chore: bump sinon from 17.0.1 to 18.0.0 (#4475)
dependabot[bot] Jun 4, 2024
e32f803
fix(landmark-unique): follow spec, aside -> landmark (#4469)
gabalafou Jun 4, 2024
68bae74
style(lib/core): var -> let and const codemod (#4457)
gaiety-deque Jun 6, 2024
2481379
ci: fix usage of deprecated `artifact` actions (#4495)
hamirmahal Jun 7, 2024
23b43dc
style(lib/rules): var -> const & let (#4493)
gaiety-deque Jun 13, 2024
3ef9353
fix: colorio.js patch mocking CSS (#4456)
gaiety-deque Jun 13, 2024
11fad59
fix: correct typos in texts (#4499)
marktnoonan Jun 17, 2024
50e7c23
chore(test/rule-matches): var -> const & let (#4497)
gaiety-deque Jun 17, 2024
e31a974
fix(autocomplete-valid): incomplete for invalid but safe values (#4500)
gaiety-deque Jun 20, 2024
0577a74
docs(projects): add a11y-audit-elixir (#4503)
angelikatyborska Jun 24, 2024
0d8a99e
feat(new-rule): summary elements must have an accessible name (#4511)
WilcoFiers Jul 1, 2024
135898b
fix(required-attr): allow aria-valuetext on slider instead of valueno…
WilcoFiers Jul 2, 2024
be406d4
chore(text): standardize rule descriptions (#4527)
marktnoonan Jul 8, 2024
deb2dcb
test(object-is-loaded-matches): prevent test flakiness by allowing mo…
dbjorge Jul 8, 2024
a2effe4
chore: bump chromedriver from 125.0.1 to 126.0.4 (#4521)
dependabot[bot] Jul 9, 2024
d0bbe98
chore: Update locale de.json (#4525)
EvilKarter Jul 9, 2024
c05cf45
chore: bump the npm-low-risk group with 13 updates (#4519)
dependabot[bot] Jul 9, 2024
f379c32
chore(summary-name): add role=button example (#4528)
WilcoFiers Jul 10, 2024
5b4cb9d
fix(aria-roledescription): keep disabled with { runOnly: 'wcag2a' } (…
WilcoFiers Jul 10, 2024
a6361bb
refactor: put isContext methods on axe.utils (#4524)
WilcoFiers Jul 10, 2024
2f5b7c3
test: don't load axe.min (#4533)
straker Jul 10, 2024
2e242e1
fix(aria-allowed-attr): allow aria-required=false when normally not a…
straker Jul 10, 2024
f019068
fix(aria-allowed-attr): allow aria-multiline=false for element with c…
straker Jul 11, 2024
07c5d91
fix(aria-prohibited-attr): allow aria-label/ledby on decendants of wi…
straker Jul 22, 2024
d579e2f
chore(release): 4.10.0
attest-team-ci Jul 29, 2024
a29af56
chore: update changelog
straker Jul 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,14 @@ jobs:
paths:
- node_modules

# Build and cache axe.js
# Build and cache built files
build_unix:
<<: *defaults
<<: *unix_box
steps:
- checkout
- <<: *restore_dependency_cache_unix
- run: npm run prepare
- run: npm run build
- save_cache:
key: v9-cache-build-<< pipeline.git.revision >>
Expand Down
3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ doc/api/*
doc/examples/jest_react/*.js

lib/core/imports/*.js
lib/core/utils/uuid.js
axe.js
axe.min.js
axe.min.js
181 changes: 0 additions & 181 deletions .eslintrc.js

This file was deleted.

6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,16 @@ updates:
versions: ['>=9.0.0']
- dependency-name: 'chai'
versions: ['>=5.0.0']
- dependency-name: 'conventional-commits-parser'
versions: ['>=6.0.0']
# Prevent Webpack error caused by v0.11+ of esbuild
# @see https://github.com/dequelabs/axe-core/issues/3771
- dependency-name: 'esbuild'
versions: ['>=0.11.0']
# Prevent colorjs.io issue caused by >v0.4.3
# @see https://github.com/dequelabs/axe-core/issues/4428
- dependency-name: 'colorjs.io'
versions: ['>0.4.3']
groups:
# Any updates not caught by the group config will get individual PRs
npm-low-risk:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ jobs:
- run: npm run fmt
# Prevent the prettierignore change from being committed.
- run: git checkout .prettierignore
- uses: stefanzweifel/git-auto-commit-action@8756aa072ef5b4a080af5dc8fef36c5d586e521d # tag=v5
- uses: stefanzweifel/git-auto-commit-action@8621497c8c39c72f3e2a999a26b4ca1b5058a842 # tag=v5
with:
commit_message: ':robot: Automated formatting fixes'
7 changes: 3 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ jobs:
node-version: 20
cache: 'npm'
- run: npm ci
- run: npm run prepare
- run: npm run build
# v4 download seems to have some flakiness with the download of artifacts so pinning to v3 for now
# @see https://github.com/actions/download-artifact/issues/249
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: axe-core
path: axe.js
Expand All @@ -39,7 +38,7 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node}}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: axe-core
- run: npm run test:node
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,3 @@ typings/axe-core/axe-core-tests.js

# doc
doc/rule-descriptions.*.md

19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,25 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [4.10.0](https://github.com/dequelabs/axe-core/compare/v4.9.1...v4.10.0) (2024-07-29)

### Features

- **new-rule:** summary elements must have an accessible name ([#4511](https://github.com/dequelabs/axe-core/issues/4511)) ([0d8a99e](https://github.com/dequelabs/axe-core/commit/0d8a99eadd8d49e5d3ea0f11ad77be732148431e)), closes [#4510](https://github.com/dequelabs/axe-core/issues/4510)

### Bug Fixes

- **aria-allowed-attr:** allow aria-multiline=false for element with contenteditable ([#4537](https://github.com/dequelabs/axe-core/issues/4537)) ([f019068](https://github.com/dequelabs/axe-core/commit/f0190685722495d00be644cabb1c9741d74acdea))
- **aria-allowed-attr:** allow aria-required=false when normally not allowed ([#4532](https://github.com/dequelabs/axe-core/issues/4532)) ([2e242e1](https://github.com/dequelabs/axe-core/commit/2e242e146929902c97e181e41fa45e656cf3eb51))
- **aria-prohibited-attr:** allow aria-label/ledby on descendants of widget ([#4541](https://github.com/dequelabs/axe-core/issues/4541)) ([07c5d91](https://github.com/dequelabs/axe-core/commit/07c5d91c658bda6bcd2743950bf70f25abd1f9ae))
- **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' } ([#4526](https://github.com/dequelabs/axe-core/issues/4526)) ([5b4cb9d](https://github.com/dequelabs/axe-core/commit/5b4cb9d7992a4c07745e64708040777de64874bd)), closes [#4523](https://github.com/dequelabs/axe-core/issues/4523)
- **autocomplete-valid:** incomplete for invalid but safe values ([#4500](https://github.com/dequelabs/axe-core/issues/4500)) ([e31a974](https://github.com/dequelabs/axe-core/commit/e31a974de395845c08af345f9458a8091e2b1c4b)), closes [#4492](https://github.com/dequelabs/axe-core/issues/4492)
- **build:** limit locales to valid files when using the --all-lang option ([#4486](https://github.com/dequelabs/axe-core/issues/4486)) ([d3db593](https://github.com/dequelabs/axe-core/commit/d3db593991261ad44eef1c142d8a4646edde93fa)), closes [#4485](https://github.com/dequelabs/axe-core/issues/4485)
- Prevent errors when loading axe in Angular + Jest ([#4456](https://github.com/dequelabs/axe-core/issues/4456)) ([3ef9353](https://github.com/dequelabs/axe-core/commit/3ef93531a574c2be76a92d59599d978714cca9d0)), closes [#4400](https://github.com/dequelabs/axe-core/issues/4400)
- Minor grammatical fixes for some rules and checks ([#4499](https://github.com/dequelabs/axe-core/issues/4499)) ([11fad59](https://github.com/dequelabs/axe-core/commit/11fad598c25eadd29f35ef6be382d907057d4537))
- **landmark-unique:** follow spec, aside -> landmark ([#4469](https://github.com/dequelabs/axe-core/issues/4469)) ([e32f803](https://github.com/dequelabs/axe-core/commit/e32f8034246a92e4132dc04f6310e2b414d6d43f)), closes [#4460](https://github.com/dequelabs/axe-core/issues/4460)
- **required-attr:** allow aria-valuetext on slider instead of valuenow ([#4518](https://github.com/dequelabs/axe-core/issues/4518)) ([135898b](https://github.com/dequelabs/axe-core/commit/135898b38d5eb46c42170527a0ac9add425c5c3d)), closes [#4515](https://github.com/dequelabs/axe-core/issues/4515)

### [4.9.1](https://github.com/dequelabs/axe-core/compare/v4.9.0...v4.9.1) (2024-05-06)

### Bug Fixes
Expand Down
10 changes: 7 additions & 3 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@ module.exports = function (grunt) {
});
} else if (grunt.option('all-lang')) {
var localeFiles = require('fs').readdirSync('./locales');
langs = localeFiles.map(function (file) {
return '.' + file.replace('.json', '');
});
langs = localeFiles
.filter(function (file) {
return !file.startsWith('_') && file.endsWith('.json');
})
.map(function (file) {
return '.' + file.replace('.json', '');
});
langs.unshift(''); // Add default
} else {
langs = [''];
Expand Down
23 changes: 18 additions & 5 deletions axe.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,19 @@ declare namespace axe {
| LabelledShadowDomSelector
| LabelledFramesSelector;
type SelectorList = Array<Selector | FramesSelector> | NodeList;
type ContextProp = Selector | SelectorList;
type ContextObject =
| {
include: Selector | SelectorList;
exclude?: Selector | SelectorList;
include: ContextProp;
exclude?: ContextProp;
}
| {
exclude: Selector | SelectorList;
include?: Selector | SelectorList;
exclude: ContextProp;
include?: ContextProp;
};
type ElementContext = Selector | SelectorList | ContextObject;
type ContextSpec = ContextProp | ContextObject;
/** Synonym to ContextSpec */
type ElementContext = ContextSpec;

type SerialSelector =
| BaseSelector
Expand Down Expand Up @@ -406,6 +409,16 @@ declare namespace axe {
shadowSelect: (selector: CrossTreeSelector) => Element | null;
shadowSelectAll: (selector: CrossTreeSelector) => Element[];
getStandards(): Required<Standards>;
isContextSpec: (context: unknown) => context is ContextSpec;
isContextObject: (context: unknown) => context is ContextObject;
isContextProp: (context: unknown) => context is ContextProp;
isLabelledFramesSelector: (
selector: unknown
) => selector is LabelledFramesSelector;
isLabelledShadowDomSelector: (
selector: unknown
) => selector is LabelledShadowDomSelector;

DqElement: new (
elm: Element,
options?: { absolutePaths?: boolean }
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "axe-core",
"version": "4.9.1",
"version": "4.10.0",
"deprecated": true,
"contributors": [
{
Expand Down
4 changes: 3 additions & 1 deletion build/cherry-pick.js
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#!/usr/bin/env node

const { execSync } = require('child_process');
const conventionalCommitsParser = require('conventional-commits-parser');
const chalk = require('chalk');
Expand Down Expand Up @@ -129,7 +131,7 @@ commitsToCherryPick.forEach(({ hash, type, scope, subject }) => {

try {
execSync(`git cherry-pick ${hash} -X theirs`);
} catch (e) {
} catch {
console.error(
chalk.red.bold('\nAborting cherry-pick and reseting to master')
);
Expand Down
2 changes: 1 addition & 1 deletion build/tasks/validate.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function fileExists(v, o) {
var exists;
try {
exists = fs.existsSync(file);
} catch (e) {
} catch {
return false;
}
return exists;
Expand Down
4 changes: 2 additions & 2 deletions doc/API.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ In this example, we pass in the WCAG 2 A and AA tags into `axe.getRules` to retr
```js
[
{
description: "Ensures <area> elements of image maps have alternate text",
description: "Ensure <area> elements of image maps have alternate text",
help: "Active <area> elements must have alternate text",
helpUrl: "https://dequeuniversity.com/rules/axe/3.5/area-alt?application=axeAPI",
ruleId: "area-alt",
Expand All @@ -162,7 +162,7 @@ In this example, we pass in the WCAG 2 A and AA tags into `axe.getRules` to retr
actIds: ['c487ae']
},
{
description: "Ensures ARIA attributes are allowed for an element's role",
description: "Ensure ARIA attributes are allowed for an element's role",
help: "Elements must only use allowed ARIA attributes",
helpUrl: "https://dequeuniversity.com/rules/axe/3.5/aria-allowed-attr?application=axeAPI",
ruleId: "aria-allowed-attr",
Expand Down
Loading
Loading