fix(aria-required-children): never fail if given aria-busy=true #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously approved these changes
Oct 31, 2024
|
Going to do a little more AT testing with aria-busy. This change may have gone by without enough scrutiny, but looking at this more closely the argument for allowing anything inside an aria-busy region is a little questionable. The ARIA 1.3 draft is even clearer that this is not the intent way to use aria-busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we made a mistake in #4347, where we allowed an element with aria-busy=true to fail if it has children it is not allowed to have. While that's a likely failure, I don't think axe can say it fails for certain.
Closes: #4626