feat: change sort col using two fixed keys #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the sort col using two fixed keys instead of using the fixed bindings per column. Another fixed key is used to change the sort order. The behaviour is now similar to `top` The implementation is based on re-evaluating which columns of the model should be visible, instead of checking the currently displayed columns. The displayed column names might be decorated with extra content which make string comparisons cumbersome. Also, fix the sorting on CAPACITY-like columns (e.g. pv, pvc) by comparing the values as a `Quantity` and not `strings`.
|
This is a great improvement! Here's to hoping it can get merged. |
|
What's the status of this? Any reason it couldn't be merged? In my case I'd love to order by assigned memory limit (not the percentage) which is not possible atm. |
|
Rebased with small fixes here: #2739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at this feature request: #1000
Description
Change the sort col using two fixed keys,
<and>.qchanges the sort order. The behaviour is now similar totopDemo
(The player doesn't show the key inputs sadly)
Implementation details
qkey instead ofrbecause it is already used in some places (e.g. node drain). I assumed you do not want to change the default keybindings even though I am personally in favour of refactoring withrageto fix sorting oncapacity, but it isn't ideal. It can lead to issues like this too: Support sort by revision #885. The original value or a specific compare function should be kept on the level of theFieldsor evenRow.Closes #1000