fix: Ignore loading context plugins with empty context (derailed/k9s#2651) #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading plugins, skip loading context-aware configurations if there is no current context (i.e. when `current-context` in the kubeconfig is empty).
tws-rdelatorre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2651
I decided to give it a shot at fixing the error message that appears when running
k9swithout a context.This PR skips loading context-aware configurations when loading plugins if there is no current context (i.e. when
current-contextin the kubeconfig is empty). Note that, if there is no current context,k9swill still try to connect to the default k8s server address, which ishttp://localhost:8080, and will end with a connection error anyway if there isn't anykube-apiserverlistening locally at that port.