-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add history navigation with [
and ]
, most recent command with -
#2799
base: master
Are you sure you want to change the base?
Conversation
be13aa3
to
f6bff90
Compare
Features from these requests not included are:
This PR implements the most powerful parts of the feature requests. Better navigation and richer history could be added later while keeping this functionality intact. Supersedes #1090 |
Tested the feature locally and I have some questions:
Is this intended? I assume these "views" are somehow different from the generic Object views (Pod, StatefulSet, Deployment, ...)? In general I really like this feature! Especially |
I think that's a good idea, just to make it clear what to expect from the feature 👍 |
I updated the README. |
Thanks! One tiny remark: Your commit changed all My 2ct would be to revert these style-changes so only the new documentation is added, but I guess @derailed has the final call here :) |
7fbfca2
to
c29dd8e
Compare
Go Back walks back through the history until at the oldest saved view Last View switches between the current and previous views like how "cd -" works
c29dd8e
to
8652c78
Compare
@KevinGimbel those formatting changes were not intentional, I've changed my settings so it doesn't happen again. While I was at it, I squashed my commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyzbit Nice work! Good concept. Just a few items to clean up and simplify.
Thank you for the great feedback. I'm working on addressing the comments; some planned changes:
|
[
and ]
, most recent command with -
15a28f4
to
7d18b1f
Compare
I've implemented history navigation via |
@derailed , any thoughts on this PR? Anything else needed to merge this? |
Go Back walks back through the history until at the oldest saved viewLast View switches between the current and previous views like how "cd -" worksEDIT: New description for the features
[
and]
to navigate the command history back[
and forward]
.-
to switch between the current screen and the last one.Example
While on the pod screen, type
:service
and enter. Hitting[
then brings you back to the pod screen. Hitting]
brings you forward in your history to the service screen. Type:ingress
and hit enter (you are taken to the Ingresses screen), then hit-
, you will go back to the service screen. Hit-
again and you will go back to the Ingresses screen.