Add --head, --form, --user and --location flags to parser #5
Conversation
|
I would be happy with a note in the documentation that we don't implement the read file syntax. If someone needs it, they can build it and contribute back a PR. Re: to_curl implementations of these options. You can either add in this PR or add a TODO at the bottom of the README to cover it. If you make those doc changes then I can merge this one. Thanks for all your contributions btw! |
|
Could you also add an entry to the CHANGELOG.md? |
|
Thanks! I will update the PR tonight |
kevinschweikert
force-pushed
the
feature/more-flags
branch
from
e3693b1
to
10634fa
Compare
|
Hey @derekkraan i've extended the PR with your suggestions and took some time to clean up the documentation and test files. Hope that's okay for you! |
kevinschweikert
force-pushed
the
feature/more-flags
branch
2 times, most recently
from
f4cbb27
to
47979aa
Compare
lib/curl_req.ex
Outdated
| def from_curl(curl_command), do: CurlReq.Macro.parse(curl_command) | ||
|
|
||
| @doc """ | ||
| Same as `from_curl/1` but as a sigil. The benefit here is, that you don't need to escape the string |
There was a problem hiding this comment.
Also, the parsing and conversion to a %Req.Request{} is done at compile-time.
kevinschweikert
force-pushed
the
feature/more-flags
branch
from
4715be7
to
2da9af0
Compare
kevinschweikert
force-pushed
the
feature/more-flags
branch
from
2da9af0
to
62d3db4
Compare
kevinschweikert
force-pushed
the
feature/more-flags
branch
from
62d3db4
to
02cff2b
Compare
kevinschweikert
force-pushed
the
feature/more-flags
branch
from
af1b8f6
to
41297ae
Compare
|
@derekkraan PR should be ready now ;) |
|
Appreciate all the effort you're putting in here! |
I've added some more flags to parse from the curl command. This should cover most use cases. Only missing thing could be to support the
@syntax in, for example,curl [URL] -d @filename.txtto load from a file. We could read the file in Elixir, but I don't know if we should support it.I didn't yet do the other direction in
to_curlin this PR for the new flags. Should i add them here or could this be a seperate PR?