Merge pull request dart-archive#46 from derekxu16/master

Fixed handling of true and false literal types
derekxu16 · Oct 9, 2019 · 6defeee · 6defeee
2 parents 4a2423f + 8b4b514
commit 6defeee
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/lib/facade_converter.ts b/lib/facade_converter.ts
@@ -474,10 +474,17 @@ export class FacadeConverter extends base.TranspilerBase {
           '<' + this.generateDartTypeName(node.elementType, addInsideTypeArgument(options)) + '>';
     } else if (node.kind === ts.SyntaxKind.NumberKeyword) {
       name = 'num';
-    } else if (node.kind === ts.SyntaxKind.LiteralType) {
-      if (ts.isLiteralTypeNode(node) && ts.isLiteralExpression(node.literal)) {
-        comment = `'${node.literal.text}'`;
+    } else if (ts.isLiteralTypeNode(node)) {
+      const literal = node.literal;
+      if (ts.isLiteralExpression(literal)) {
+        comment = `'${literal.text}'`;
         name = 'String';
+      } else if (literal.kind === ts.SyntaxKind.TrueKeyword) {
+        name = 'bool';
+        comment = 'true';
+      } else if (literal.kind === ts.SyntaxKind.FalseKeyword) {
+        name = 'bool';
+        comment = 'false';
       }
     } else if (ts.isStringLiteral(node) || node.kind === ts.SyntaxKind.StringKeyword) {
       name = 'String';

diff --git a/test/type_test.ts b/test/type_test.ts
@@ -31,6 +31,12 @@ abstract class Foo {
   external Foo bar();
 }`);
   });
+  it('supports true and false return types', () => {
+    expectTranslate('export function f(): true;').to.equal(`@JS()
+external bool /*true*/ f();`);
+    expectTranslate('export function g(): false;').to.equal(`@JS()
+external bool /*false*/ g();`);
+  });
 
   it('comment type literals', () => {
     expectTranslate('var x: {x: string, y: number};').to.equal(`@JS()