[TASK] Minor CGL changes

derhansen · Jan 5, 2019 · 575a34c · 575a34c
1 parent ced6622
commit 575a34c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Classes/YubikeyAuth.php b/Classes/YubikeyAuth.php
@@ -58,7 +58,7 @@ public function checkOtp($yubikeyOtp)
         $ret = false;
         $otp = trim($yubikeyOtp);
 
-        // Verify if the OTP is valid ?
+        // Verify if the OTP is valid
         if ($this->verifyOtp($otp)) {
             $ret = true;
         }
@@ -106,7 +106,6 @@ public function verifyHmac($response, $yubicoApiKey)
      */
     public function verifyOtp($otp)
     {
-
         // Get the global API ID/KEY
         $yubicoApiId = trim($this->getConfig('yubikeyClientId'));
         $yubicoApiKey = trim($this->getConfig('yubikeyClientKey'));
@@ -132,6 +131,7 @@ public function verifyOtp($otp)
         );
         $signature = preg_replace('/\+/', '%2B', $signature);
         $parameters .= '&h=' . $signature;
+        $urls = [];
         foreach ($apiUrls as $apiUrl) {
             $urls[] = $apiUrl . '?' . $parameters;
         }
@@ -148,6 +148,7 @@ public function verifyOtp($otp)
         }
 
         $mh = curl_multi_init();
+        $connections = [];
         foreach ($urls as $i => $url) {
             $connections[$i] = curl_init($url);
             $curlOptions[CURLOPT_URL] = $url;