Add support for decimal values in relative time expressions #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

khaledalam wants to merge 1 commit into derickr:master from khaledalam:strtotime-decimal-relative

khaledalam commented Jan 26, 2026

Description

This PR adds support for decimal values in relative time expressions (e.g., 2.5 weeks, 1.5 days, 3.14159 hours).

Fixes: php/php-src#21027

PR on php-src: php/php-src#21034

Problem

strtotime("2.37685 weeks") returned incorrect result (~414 million seconds instead of ~1.4 million) because:

"2.37" matched timeshort24 pattern (hour:minute with dot separator)
"685 weeks" was parsed as separate relative offset

Changes

Added reldecimalnumber regex pattern for decimal numbers
Added reldecimal lexer rule to match decimal relative expressions
Added timelib_get_decimal_nr() helper to parse decimal values
Added timelib_set_relative_decimal() to convert decimal units to seconds
Added test cases for decimal relative time parsing


          feat: Add support for decimal values in relative time expressions.

db01a03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet