Fixed too fast e2e auth tests (😱) and updated playwright config for q…

…uicker timeouts

e2e/pages/AuthPage.ts

@@ -27,12 +27,15 @@ export class AuthPage {
 	}
 
 	async clearLocalStorage() {
-		await this.page.evaluate(() => localStorage.clear());
+		await this.page.waitForFunction(() => {
+			localStorage.clear();
+			return true;
+		});
 	}
 
 	async hasLocalStorageSecret() {
-		return await this.page.evaluate(
-			() => localStorage.getItem("notSoSecretSecret") !== null,
-		);
+		return await this.page.evaluate(() => {
+			return localStorage.getItem("notSoSecretSecret") !== null;
+		});
 	}
 }

e2e/pages/MainPage.ts

@@ -9,13 +9,17 @@ export class MainPage {
 	constructor(public readonly page: Page) {
 		this.noteInput = page.getByLabel("New spark");
 		this.submitButton = page.getByRole("button", { name: "Add" });
-		this.sparkList = page.getByRole("list", { name: "Sparks" });
+		this.sparkList = page
+			.getByText("Sparks")
+			.locator("..") // parent node
+			.getByRole("list");
 	}
 
 	async goto() {
 		const url = createUrl();
 		await this.page.goto(url);
 		await authenticate(this.page);
+		await this.page.goto(url);
 	}
 
 	async fillNote(password: string) {

e2e/tests/auth.test.ts

@@ -12,16 +12,26 @@ test.describe("Auth", () => {
 			expect(process.env.NOT_SO_SECRET_SECRET).not.toBe(undefined);
 		}
 
+		// needed because astro hydration is sometimes not fast enough
+		// and then the form submits with the usual GET behavior
+		// This timeout should allow the hydration to finish
+		await authPage.page.waitForTimeout(1000);
+
 		await authPage.enterPassword(process.env.NOT_SO_SECRET_SECRET ?? "");
 		await authPage.submit();
-		// Expect a title "to contain" a substring.
+
 		await expect(await authPage.hasLocalStorageSecret()).toBe(true);
 	});
 
 	test("shows error for wrong secret", async ({ authPage }) => {
 		await authPage.enterPassword("wrong-secret");
 		await authPage.submit();
-		// Expect a title "to contain" a substring.
+
+		// needed because astro hydration is sometimes not fast enough
+		// and then the form submits with the usual GET behavior
+		// This timeout should allow the hydration to finish
+		await authPage.page.waitForTimeout(1000);
+
 		await expect(await authPage.getErrorMessage()).toBe(
 			"😢 Sadly that is not correct.",
 		);

playwright.config.ts

@@ -78,8 +78,8 @@ export default defineConfig({
 		reuseExistingServer: !process.env.CI,
 	},
 
-	timeout: 3000,
+	timeout: 6000,
 	expect: {
-		timeout: 3000,
+		timeout: 6000,
 	},
 });