Implement Bank Transfer

descom-es · Nov 3, 2023 · ed7694f · ed7694f
1 parent b7f06b3
commit ed7694f
Show file tree

Hide file tree

Showing 18 changed files with 59 additions and 64 deletions.
diff --git a/README.md b/README.md
@@ -1,15 +1,12 @@
-# Omnipay:: Offline dummy
+# Omnipay:: Bank transfer
 
-Omnipay Offline Dummy Gateway for testing
+Omnipay bank Transfer Gateway
 
-[![tests](https://github.com/descom-es/omnipay-offline-dummy/actions/workflows/tests.yml/badge.svg)](https://github.com/descom-es/omnipay-offline-dummy/actions/workflows/tests.yml)
-[![analyse](https://github.com/descom-es/omnipay-offline-dummy/actions/workflows/analyse.yml/badge.svg)](https://github.com/descom-es/omnipay-offline-dummy/actions/workflows/analyse.yml)
-[![style-fix](https://github.com/descom-es/omnipay-offline-dummy/actions/workflows/style-fix.yml/badge.svg)](https://github.com/descom-es/omnipay-offline-dummy/actions/workflows/style-fix.yml)
 
 ## Instalation
 
 ```sh
-composer require descom/omnipay-offline-dummy
+composer require descom/omnipay-bank-transfer
 ```
 
 ## Basic Usage
@@ -19,7 +16,7 @@ composer require descom/omnipay-offline-dummy
 ```php
 use Omnipay\Omnipay;
 
-$gateway = Omnipay::create('OfflineDummy');
+$gateway = Omnipay::create('BankTransfer');
 
 $request = $gateway->purchase([
                 'amount' => '12.00',

diff --git a/composer.json b/composer.json
@@ -1,16 +1,16 @@
 {
-    "name": "descom/omnipay-offline-dummy",
-    "description": "Omnipay Offline Dummy Gateway for testing",
+    "name": "descom/omnipay-bank-transfer",
+    "description": "Omnipay Bank Transfer Gateway",
     "type": "library",
     "license": "MIT",
     "autoload": {
         "psr-4": {
-            "Omnipay\\OfflineDummy\\": "src/"
+            "Omnipay\\BankTransfer\\": "src/"
         }
     },
     "autoload-dev": {
         "psr-4": {
-            "Omnipay\\OfflineDummy\\Tests\\": "tests/"
+            "Omnipay\\BankTransfer\\Tests\\": "tests/"
         }
     },
     "authors": [
@@ -40,8 +40,8 @@
     "extra": {
         "laravel": {
             "providers": [
-                "Omnipay\\OfflineDummy\\App\\AppServiceProvider"
+                "Omnipay\\BankTransfer\\App\\AppServiceProvider"
             ]
         }
     }
-}
+}
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -10,7 +10,4 @@ parameters:
     # The level 9 is the highest level
     level: 5
 
-    checkMissingIterableValueType: false
-
-    ignoreErrors:
-        - '#Property Omnipay\\OfflineDummy\\Tests.* \(Omnipay\\OfflineDummy\\Gateway\) does not accept Omnipay\\Common\\GatewayInterface.#'
+    checkMissingIterableValueType: false
diff --git a/resources/views/payment.blade.php b/resources/views/payment.blade.php
@@ -100,9 +100,10 @@
 <body>
     <div class="container">
         <header>
-            <h1>Método de pago de pruebas</h1>
+            <h1>Método de pago de transferencia bancaria</h1>
             <p>
-                Este método de pago ha sido desarrollado por Descom para testear los procesos de compra.
+                Este método de pago ha sido desarrollado por Descom para realizar procesos de compra por transferencia
+                bancaria.
             </p>
         </header>
 
@@ -133,4 +134,4 @@
     </div>
 </body>
 
-</html>
+</html>
diff --git a/src/App/App.php b/src/App/App.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Omnipay\OfflineDummy\App;
+namespace Omnipay\BankTransfer\App;
 
 class App
 {

diff --git a/src/App/AppServiceProvider.php b/src/App/AppServiceProvider.php
@@ -1,12 +1,12 @@
 <?php
 
-namespace Omnipay\OfflineDummy\App;
+namespace Omnipay\BankTransfer\App;
 
 use Illuminate\Foundation\Http\Middleware\VerifyCsrfToken;
 use Illuminate\Support\Facades\Route;
 use Illuminate\Support\ServiceProvider;
-use Omnipay\OfflineDummy\App\Http\Controllers\PaymentController;
-use Omnipay\OfflineDummy\App\Http\Controllers\PaymentProcessController;
+use Omnipay\BankTransfer\App\Http\Controllers\PaymentController;
+use Omnipay\BankTransfer\App\Http\Controllers\PaymentProcessController;
 
 class AppServiceProvider extends ServiceProvider
 {
@@ -19,7 +19,7 @@ public function boot()
     {
         $this->registerRouters();
 
-        $this->loadViewsFrom(__DIR__ . '/../../resources/views', 'omnipay-offline-dummy');
+        $this->loadViewsFrom(__DIR__ . '/../../resources/views', 'omnipay-bank-transfer');
     }
 
     private function registerRouters(): void

diff --git a/src/App/Http/Controllers/PaymentController.php b/src/App/Http/Controllers/PaymentController.php
@@ -1,10 +1,10 @@
 <?php
 
-namespace Omnipay\OfflineDummy\App\Http\Controllers;
+namespace Omnipay\BankTransfer\App\Http\Controllers;
 
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
-use Omnipay\OfflineDummy\App\App;
+use Omnipay\BankTransfer\App\App;
 
 class PaymentController extends Controller
 {
@@ -16,7 +16,7 @@ public function __invoke(Request $request)
             'amount' => 'required|numeric',
         ]);
 
-        return view('omnipay-offline-dummy::payment', [
+        return view('omnipay-bank-transfer::payment', [
             'transactionId' => $request->input('transaction_id'),
             'description' => $request->input('description'),
             'amount' => $request->input('amount'),

diff --git a/src/App/Http/Controllers/PaymentProcessController.php b/src/App/Http/Controllers/PaymentProcessController.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Omnipay\OfflineDummy\App\Http\Controllers;
+namespace Omnipay\BankTransfer\App\Http\Controllers;
 
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
@@ -11,7 +11,7 @@ class PaymentProcessController extends Controller
 {
     public function __invoke(Request $request)
     {
-        $gateway = Omnipay::create('OfflineDummy');
+        $gateway = Omnipay::create('BankTransfer');
 
         $response = $gateway->completePurchase($request->all())->send();
 

diff --git a/src/Gateway.php b/src/Gateway.php
@@ -1,16 +1,16 @@
 <?php
 
-namespace Omnipay\OfflineDummy;
+namespace Omnipay\BankTransfer;
 
 use Omnipay\Common\AbstractGateway;
-use Omnipay\OfflineDummy\Message\CompletedPurchaseRequest;
-use Omnipay\OfflineDummy\Message\PurchaseRequest;
+use Omnipay\BankTransfer\Message\CompletedPurchaseRequest;
+use Omnipay\BankTransfer\Message\PurchaseRequest;
 
 class Gateway extends AbstractGateway
 {
     public function getName()
     {
-        return 'OfflineDummy';
+        return 'Bank Transfer';
     }
 
     public function getDefaultParameters()

diff --git a/src/Message/CompletedPurchaseRequest.php b/src/Message/CompletedPurchaseRequest.php
@@ -1,9 +1,9 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Message;
+namespace Omnipay\BankTransfer\Message;
 
 use Omnipay\Common\Message\AbstractRequest;
-use Omnipay\OfflineDummy\App\App;
+use Omnipay\BankTransfer\App\App;
 
 /**
  * PayFast Purchase Request

diff --git a/src/Message/CompletedPurchaseResponse.php b/src/Message/CompletedPurchaseResponse.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Message;
+namespace Omnipay\BankTransfer\Message;
 
 use Omnipay\Common\Message\AbstractResponse;
 

diff --git a/src/Message/PurchaseRequest.php b/src/Message/PurchaseRequest.php
@@ -1,9 +1,9 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Message;
+namespace Omnipay\BankTransfer\Message;
 
 use Omnipay\Common\Message\AbstractRequest;
-use Omnipay\OfflineDummy\App\App;
+use Omnipay\BankTransfer\App\App;
 
 /**
  * PayFast Purchase Request

diff --git a/src/Message/PurchaseResponse.php b/src/Message/PurchaseResponse.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Message;
+namespace Omnipay\BankTransfer\Message;
 
 use Omnipay\Common\Message\AbstractResponse;
 use Omnipay\Common\Message\RedirectResponseInterface;
@@ -24,7 +24,7 @@ public function isSuccessful()
 
     public function isRedirect()
     {
-        return true;
+        return false;
     }
 
     public function getRedirectUrl()

diff --git a/tests/AppTest.php b/tests/AppTest.php
@@ -1,10 +1,10 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Tests;
+namespace Omnipay\BankTransfer\Tests;
 
 use Illuminate\Support\Facades\Http;
-use Omnipay\OfflineDummy\App\App;
-use Omnipay\OfflineDummy\Gateway;
+use Omnipay\BankTransfer\App\App;
+use Omnipay\BankTransfer\Gateway;
 use Omnipay\Omnipay;
 
 class AppTest extends TestCase
@@ -15,7 +15,7 @@ public function setUp(): void
     {
         parent::setUp();
 
-        $this->gateway = Omnipay::create('OfflineDummy');
+        $this->gateway = Omnipay::create('BankTransfer');
     }
 
     public function testPurchase()

diff --git a/tests/CompletedPurchaseTest.php b/tests/CompletedPurchaseTest.php
@@ -1,11 +1,11 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Tests;
+namespace Omnipay\BankTransfer\Tests;
 
-use Omnipay\OfflineDummy\App\App;
-use Omnipay\OfflineDummy\Gateway;
-use Omnipay\OfflineDummy\Message\CompletedPurchaseRequest;
-use Omnipay\OfflineDummy\Message\CompletedPurchaseResponse;
+use Omnipay\BankTransfer\App\App;
+use Omnipay\BankTransfer\Gateway;
+use Omnipay\BankTransfer\Message\CompletedPurchaseRequest;
+use Omnipay\BankTransfer\Message\CompletedPurchaseResponse;
 use Omnipay\Omnipay;
 
 class CompletedPurchaseTest extends TestCase
@@ -16,7 +16,7 @@ public function setUp(): void
     {
         parent::setUp();
 
-        $this->gateway = Omnipay::create('OfflineDummy');
+        $this->gateway = Omnipay::create('BankTransfer');
     }
 
     public function testCompletedPurchaseRequest()

diff --git a/tests/GatewayTest.php b/tests/GatewayTest.php
@@ -1,8 +1,8 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Tests;
+namespace Omnipay\BankTransfer\Tests;
 
-use Omnipay\OfflineDummy\Gateway;
+use Omnipay\BankTransfer\Gateway;
 use Omnipay\Tests\GatewayTestCase;
 
 class GatewayTest extends GatewayTestCase

diff --git a/tests/PurchaseTest.php b/tests/PurchaseTest.php
@@ -1,10 +1,10 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Tests;
+namespace Omnipay\BankTransfer\Tests;
 
-use Omnipay\OfflineDummy\Gateway;
-use Omnipay\OfflineDummy\Message\PurchaseRequest;
-use Omnipay\OfflineDummy\Message\PurchaseResponse;
+use Omnipay\BankTransfer\Gateway;
+use Omnipay\BankTransfer\Message\PurchaseRequest;
+use Omnipay\BankTransfer\Message\PurchaseResponse;
 use Omnipay\Omnipay;
 
 class PurchaseTest extends TestCase
@@ -15,7 +15,7 @@ public function setUp(): void
     {
         parent::setUp();
 
-        $this->gateway = Omnipay::create('OfflineDummy');
+        $this->gateway = Omnipay::create('BankTransfer');
     }
 
     public function testPurchaseRequest()
@@ -49,10 +49,10 @@ public function testPurchaseRedirect()
         $responseHtml = $this->gateway
             ->purchase(
                 [
-                'amount' => '12.00',
-                'description' => 'Test purchase',
-                'transactionId' => 1,
-            ]
+                    'amount' => '12.00',
+                    'description' => 'Test purchase',
+                    'transactionId' => 1,
+                ]
             )->send()
             ->getRedirectResponse()
             ->getContent();

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -1,8 +1,8 @@
 <?php
 
-namespace Omnipay\OfflineDummy\Tests;
+namespace Omnipay\BankTransfer\Tests;
 
-use Omnipay\OfflineDummy\App\AppServiceProvider;
+use Omnipay\BankTransfer\App\AppServiceProvider;
 
 class TestCase extends \Orchestra\Testbench\TestCase
 {