Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to new set_password APIs #31

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Conversation

guyp-descope
Copy link
Collaborator

Deprecated the user.set_password API by creating two new functions:
user.set_temporary_password(..)
user.set_active_password(..)
The first is the same as the old set_password API and the second set the password and make it active - means it can be used on next login without automatically expired it.

Copy link
Collaborator

@ami-descope ami-descope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align def

lib/descope/api/v1/management/user.rb Outdated Show resolved Hide resolved
lib/descope/api/v1/management/user.rb Outdated Show resolved Hide resolved
@guyp-descope guyp-descope marked this pull request as ready for review February 20, 2024 15:46
Copy link
Collaborator

@ami-descope ami-descope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved 🟢

@guyp-descope guyp-descope merged commit 9928845 into main Feb 22, 2024
1 check passed
@guyp-descope guyp-descope deleted the add-password-expiration-flag branch February 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants