Rework targeted modules #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desht
reviewed
Nov 22, 2024
src/main/java/me/desht/modularrouters/item/module/SenderModule3.java
Outdated
Show resolved
Hide resolved
desht
reviewed
Nov 24, 2024
src/main/java/me/desht/modularrouters/item/module/ITargetedModule.java
Outdated
Show resolved
Hide resolved
|
Other than that really minor unused param fix, I think this is about ready to merge. Confirmed all the game tests worked for me as well, nice job on that 👍 |
desht
approved these changes
Nov 24, 2024
desht
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Rework targeted modules * Add some game tests * Fix a couple of bugs discovered by game tests 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs some testing