Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instagram data source to oracle script #125

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Aug 15, 2023

This PR adds Instagram data source to oracle script.

Description

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Updated the documentation.
  • Re-reviewed Files changed in the Github PR explorer.

@dadamu dadamu requested a review from RiccardoM August 15, 2023 07:57
@@ -6,6 +6,9 @@ const DATA_SOURCE_GITHUB: i64 = 63;
const DATA_SOURCE_DISCORD: i64 = 62;
const DATA_SOURCE_TWITCH: i64 = 60;
const DATA_SOURCE_DOMAIN: i64 = 67;
const DATA_SOURCE_YOUTUBE: i64 = 101;
const DATA_SOURCE_TELEGRAM: i64 = 102;
const DATA_SOURCE_INSTAGRAM: i64 = 0;
Copy link
Contributor Author

@dadamu dadamu Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't upload the Instagram data source ID to main net since I don't have mainnet deployer key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can wait until the data source has been deployed to merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dadamu dadamu marked this pull request as draft August 15, 2023 14:56
@dadamu dadamu marked this pull request as ready for review August 16, 2023 10:07
@RiccardoM RiccardoM merged commit 875b9ee into main Aug 16, 2023
7 checks passed
@RiccardoM RiccardoM deleted the paul/SDK-22/add-instagram-to-oracle-script branch August 16, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants