Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize performance of blocking functions #27

Merged
merged 13 commits into from
Jul 21, 2024
Merged

Conversation

destel
Copy link
Owner

@destel destel commented Jul 15, 2024

Replaced Breakable approach with atomic variables. This made ForEach as fast as ErrGroup+WorkerPool

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (cd73239) to head (5d76613).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   98.91%   98.95%   +0.03%     
==========================================
  Files          15       16       +1     
  Lines         740      765      +25     
==========================================
+ Hits          732      757      +25     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@destel destel changed the title Optimize bloking functions Optimize performance of blocking functions Jul 21, 2024
@destel destel merged commit a7c2c3f into main Jul 21, 2024
3 checks passed
@destel destel deleted the fix/optimize-breakable branch July 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant