[AUTO-BACKPORT 10160] fix: maxPoolSlotCapacity bug (#10195)

Co-authored-by: John Kim <97752292+johnkim-det@users.noreply.github.com>
determined-ai · Nov 4, 2024 · bb6f140 · bb6f140
1 parent 7db183e
commit bb6f140
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/webui/react/src/components/HyperparameterSearchModal.tsx b/webui/react/src/components/HyperparameterSearchModal.tsx
@@ -291,7 +291,18 @@ const HyperparameterSearchModal = ({ closeModal, experiment, trial }: Props): JS
   );
 
   const maxSlots = useMemo(
-    () => (resourcePool ? maxPoolSlotCapacity(resourcePool) : 0),
+    /**
+     * On-premise deployments don't have dynamic agents and we don't know how many
+     * agents might connect.
+     *
+     * This is a work around for dynamic agents such as Kubernetes where `slotsAvailable`,
+     * `slotsPerAgents` and `maxAgents` are all zero. This value is used for form
+     * validation and it is too strict to allow anything to run experiments. Intentially
+     * generalized and not matching against Kubernetes, in case other schedulers return
+     * zeroes, and this would at least unblock experiments, and the backend would be able
+     * to return capacity issues.
+     */
+    () => (resourcePool ? maxPoolSlotCapacity(resourcePool) || Infinity : 0),
     [resourcePool],
   );
 

diff --git a/webui/react/src/stores/cluster.tsx b/webui/react/src/stores/cluster.tsx
@@ -49,18 +49,7 @@ export const maxPoolSlotCapacity = (pool: ResourcePool): number => {
   if (pool.maxAgents > 0 && pool.slotsPerAgent && pool.slotsPerAgent > 0) {
     return pool.maxAgents * pool.slotsPerAgent;
   }
-  /**
-   * On-premise deployments don't have dynamic agents and we don't know how many
-   * agents might connect.
-   *
-   * This is a work around for dynamic agents such as Kubernetes where `slotsAvailable`,
-   * `slotsPerAgents` and `maxAgents` are all zero. This value is used for form
-   * validation and it is too strict to allow anything to run experiments. Intentially
-   * generalized and not matching against Kubernetes, in case other schedulers return
-   * zeroes, and this would at least unblock experiments, and the backend would be able
-   * to return capacity issues.
-   */
-  return pool.slotsAvailable || Infinity;
+  return pool.slotsAvailable;
 };
 
 /**