Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds proper MacOS bundle and icons for Windows builds #381

Merged
merged 10 commits into from
Jul 4, 2024
Merged

Adds proper MacOS bundle and icons for Windows builds #381

merged 10 commits into from
Jul 4, 2024

Conversation

dethrace-labs
Copy link
Owner

@dethrace-labs dethrace-labs commented Jun 27, 2024 •
edited
Loading

  • MacOS binary bundled with the SDL dependency as a .app , distributed inside a disk image.
  • Windows binary contains an icon

Windows:
Screenshot 2024-07-03 at 1 55 46 PM

MacOS:
Screenshot 2024-07-03 at 1 56 47 PM

Fixes #351

madebr
madebr reviewed Jun 27, 2024
View reviewed changes
src/DETHRACE/CMakeLists.txt Outdated Show resolved Hide resolved
@dethrace-labs dethrace-labs marked this pull request as ready for review July 3, 2024 02:00
madebr
madebr reviewed Jul 3, 2024
View reviewed changes
src/DETHRACE/CMakeLists.txt Outdated Show resolved Hide resolved
@dethrace-labs dethrace-labs merged commit 6836035 into main Jul 4, 2024
6 checks passed
@dethrace-labs dethrace-labs deleted the macos-bundle branch July 4, 2024 21:12
@dethrace-labs dethrace-labs mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebr madebr madebr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot start dethrace from terminal (Windows)
2 participants
@dethrace-labs @madebr