Fix some Address Sanitizer errors #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
reviewed
Jul 5, 2024
Comment on lines
+13
to
+16
| if (DETHRACE_ASAN) | ||
| target_compile_options(dethrace_obj PUBLIC -fsanitize=address) | ||
| target_link_options(dethrace_obj PUBLIC -fsanitize=address) | ||
| endif() |
There was a problem hiding this comment.
Perhaps we should do this in the top CMakeList.txt, and do the following instead?
add_compile_options(-fsanitize=address)
add_link_options(-fsanitize=addres)Then we are sure everything is built with address sanitizer (including brender and 3rd party deps).
Or don't we want to build those with sanitizer support?
There was a problem hiding this comment.
My intention was to only target dethrace. BRender already has its own sanitizer config and I didn't want to wade into the 3rd party deps!
There was a problem hiding this comment.
That makes sense :)
I generally don't use the dethrace asan options, and configure the project with -DCMAKE_C_FLAGS="-fsanitize=address and -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address".
madebr
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running with address sanitizer raised a couple of errors:
CollCheckmade some assumptions that the colliding object is atCar_spec, when it could be atNon_car_spec.CreateSplashmakes similar assumptions.A fairly reliable repro is to collide with the wrecked car next to the water in Maim Street and knock it into the water