fix: Move feedback widget to nav bar bug icon (#159)#161
Merged
deucebucket merged 3 commits intodevelopfrom Feb 19, 2026
Merged
fix: Move feedback widget to nav bar bug icon (#159)#161deucebucket merged 3 commits intodevelopfrom
deucebucket merged 3 commits intodevelopfrom
Conversation
Remove the fixed-position floating feedback button from the bottom-right corner and replace it with a bug icon in the top navigation bar that triggers the same showFeedbackModal() function. All modal dialogs, toast notifications, and JS functions remain unchanged.
- Version badge in README matches APP_VERSION - CHANGELOG entry for feedback widget relocation - README Recent Changes updated
There was a problem hiding this comment.
🔍 Vibe Check Review
Context
Moves the feedback/bug-report trigger from a fixed floating button (bottom-right) to a bi-bug icon in the top navigation bar, eliminating overlap with the dashboard's Quick Actions button.
Codebase Patterns I Verified
- Nav-bar click handlers: The existing
d-flex align-items-centerzone uses inlineonclickhandlers (onclick="showUpdateModal()",onclick="checkForUpdate()") and inlinestyleattributes — the new<a>element matches this pattern exactly. feedback-btnreferences: Searched all.pyand.htmlfiles — zero references to the oldfeedback-btnID remain. Clean removal, no orphaned selectors.showFeedbackModal()/feedbackModal: Not present in the current develop checkout, but the diff context lines confirm they live in the PR branch'sbase.html(introduced by PR #158). The modal HTML is unchanged/context-only in this diff — correct, the PR only moves the trigger.- Version bump consistency:
app.py,CHANGELOG.md, andREADME.mdall agree on0.9.0-beta.129.
✅ Good
- Floating fixed button removed entirely, including its
<style>block — no CSS leakage. href="#"+return false;correctly prevents page-top scroll-jump, matching expected link behavior.- Title changed from "Send Feedback" to "Report Bug" — semantically matches the
bi-bugicon swap. bi-bugis a Bootstrap Icons icon that already ships with the project (other BI icons used throughout).- No changes to the feedback modal itself or any error auto-reporting code — scope is surgical.
- Docs updated correctly: CHANGELOG, README badge, and README recent-changes section all updated.
🚨 Issues Found
No issues found.
📋 Scope Verification
| Issue | Problem | Addressed? | Notes |
|---|---|---|---|
| #159 | Floating button conflicts with dashboard Quick Actions, inconsistent across pages | ✅ | Bug icon in nav, floating button fully removed, modal unchanged |
Scope Status: SCOPE_OK
📝 Documentation Check
- CHANGELOG.md: ✅ Updated — correct version, accurate description
- README.md: ✅ Updated — badge and recent-changes section reflect beta.129
🎯 Verdict
APPROVE — Clean, minimal, does exactly what it says. No security, error handling, or logic concerns. The nav-bar pattern matches existing code. Ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.htmlbi-bug) to the top navigation bar that triggers the existingshowFeedbackModal()functionCloses #159