Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isFixupCommit and isMergeCommit properties #35

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Kevin-de-Jong
Copy link
Contributor

This commit adds the isFixupCommit and isMergeCommit properties to both Commit and ConventionalCommit classes.

Current implementation is straightforward and only concerns the commit message subject:

  • Fixup: subject starts with fixup!
  • Merge: support for default merge commit message patterns of GitHub, BitBucket and GitLab

These properties can be used to (for example) ignore Conventional Commit message validation for these types of commits.

Implements #33

This commit adds the `isFixupCommit` and `isMergeCommit`
properties to both Commit and ConventionalCommit classes.

Current implementation is straightforward and only concerns the
commit message subject:

- Fixup: subject starts with `fixup!`
- Merge: support for default merge commit message patterns of
         GitHub, BitBucket and GitLab

These properties can be used to (for example) ignore Conventional
Commit message validation for these types of commits.

Implements #33
@Kevin-de-Jong Kevin-de-Jong merged commit bee1d87 into main Jan 17, 2024
5 checks passed
@Kevin-de-Jong Kevin-de-Jong deleted the feat/fixup-and-merge-attributes branch January 17, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant