-
Notifications
You must be signed in to change notification settings - Fork 1
PR 템플릿 생성 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dev-hjJoo
wants to merge
1
commit into
main
Choose a base branch
from
pr_template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PR 템플릿 생성 #15
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # 📢 Checklistt | ||
| * [ ] Reviewers, Asignees, Labels, Projects를 할당해주세요. | ||
| * Labels는 새로운 문제의 경우 `enhancement`를 설정해주세요. | ||
| * Projects는 처음 생성 시 Status를 `In Progress`로 설정해주세요. | ||
| * 코드 리뷰를 마친 후 Projects의 Status를 `Done`으로 변경해주세요. | ||
| * [ ] PR의 타이틀은 `[주차] 문제 이름`으로 설정해주세요. (예: [W3] 플로이드) | ||
| * [ ] 브랜치 이름은 `(user_key)_(주차)_(문제 순서)`로 설정해주세요. | ||
| * 만약 2주차 두 번째 업로드 문제라면 **hyoz_w2_2**와 같이 설정합니다. | ||
| * 만약 2주차 두 번째 스터디 날 공식 업로드 문제 외 추가 문제를 업로드 하고 싶다면 뒤에 추가 문제 번호를 붙여주세요. (예: hyoz_w2_2_1, hyoz_w2_2_2, ...) | ||
| * [ ] PR 올리기 전에 위 내용이 완료되었는지 검토 후 요청 바랍니다. | ||
|
|
||
| # 관련 이슈 | ||
| > #이슈 번호 | ||
|
|
||
| # 작업 내용 | ||
|
|
||
| # 문제 요약 | ||
|
|
||
| # 고민 방향 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
늦게 확인해서 죄송합니다. 양식은 너무 깔끔하고 좋습니다.
그런데 앞으로 주 1회만 진행하도록 변경되면서 _(문제순서) 부분은 제거해도 괜찮지 않을까 싶은데 어떻게 생각하시나요?