BNS domains that resolve to addresses now searchable #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-ptera
reviewed
Dec 6, 2024
| async fetchBNSDomain(domain_name: string, tld: string): Promise<any> { | ||
| await this._hasPingedApi(); | ||
| return this._http | ||
| .post<any>(`${this.httpApi}/v1/account/bns`, { |
There was a problem hiding this comment.
Could we get some stronger typings here? The api is versioned so we should know what schema to expect.
Specifically looking to remove the any here.
dev-ptera
reviewed
Dec 6, 2024
Comment on lines
125
to
135
| if (!address.startsWith('ban_')) { | ||
| const parts = address.split('.'); | ||
| if (parts.length === 2) { | ||
| //search in api | ||
| try { | ||
| const domain = await this.apiService.fetchBNSDomain(parts[0], parts[1]); | ||
| if (domain.domain?.resolved_address) { | ||
| return this._redirectToAccountPage(domain.domain?.resolved_address); | ||
| } | ||
| } catch (_) {} | ||
| } |
There was a problem hiding this comment.
Could we get a quick comment here explaining what this does? If not a ban address, assume it's BNS?
dev-ptera
reviewed
Dec 6, 2024
Comment on lines
51
to
55
| isValidBNSDomain(bns: string): boolean { | ||
| const parts = bns.split('.'); | ||
| //later, can also check for illegal characters once that is more settled | ||
| return parts.length === 2 && parts[0].length <= 32; | ||
| } |
There was a problem hiding this comment.
Could this be placed in the UtilService & then used here & in the AccountComponent?
dev-ptera
reviewed
Dec 6, 2024
| if (!address) { | ||
| return; | ||
| } | ||
|
|
||
| if (!address.startsWith('ban_')) { | ||
| const parts = address.split('.'); | ||
| if (parts.length === 2) { |
There was a problem hiding this comment.
Use isValidBNSDomain utility function here?
|
@dev-ptera Hopefully that should address the review. I did add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested and working locally