Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update for Tonic v0.12 #60

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat!: Update for Tonic v0.12 #60

merged 3 commits into from
Jul 25, 2024

Conversation

cdata
Copy link
Contributor

@cdata cdata commented Jul 24, 2024

Hi, I'm considering using this crate, but my project is using Tonic at v0.12, which brings in some other updated dependencies as well. I took a stab at updating this crate to work with the new APIs. I'm opening this PR in case it is a useful basis for your own work to update the dependencies upstream.

@devashishdxt
Copy link
Owner

Hi @cdata. Thanks for creating this PR. Can you update the crate versions in gzip tests as well and fix clippy errors?

@devashishdxt devashishdxt self-requested a review July 25, 2024 08:23
@devashishdxt devashishdxt merged commit 46b9051 into devashishdxt:main Jul 25, 2024
5 checks passed
@gRoussac
Copy link

gRoussac commented Jul 25, 2024

This commit seems to address filtoid/tonic-web-wasm-client-example#1 not compiling with 0.5.1 not really sure why though

error was

error[E0277]: the trait bound `Client: Service<request::Request<http_body_util::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, Status>>>` is not satisfied
  --> src/lib.rs:22:30
   |
22 |     let mut greeter_client = GreeterServiceClient::new(wasm_client);
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Service<request::Request<http_body_util::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, Status>>>` is not implemented for `Client`, which is required by `Client: GrpcService<http_body_util::combinators::box_body::UnsyncBoxBody<prost::bytes::Bytes, Status>>

@devashishdxt
Copy link
Owner

Released a new version on crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants