Allow variable substitution default value containing a colon#882
Draft
grthr wants to merge 4 commits intodevcontainers:mainfrom
Draft
Allow variable substitution default value containing a colon#882grthr wants to merge 4 commits intodevcontainers:mainfrom
grthr wants to merge 4 commits intodevcontainers:mainfrom
Conversation
chrmarti
requested changes
Aug 30, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the PR. Left a comment with my thoughts.
| // try to separate variable arguments from variable name | ||
| let args: string[] = []; | ||
| const parts = variable.split(':'); | ||
| const parts = variable.split(':', 3); |
Contributor
There was a problem hiding this comment.
This would prevent us from introducing additional arguments in the future because we would break existing configs.
Also: split() with the limit argument does not include the remaining part of the text after the limit was hit. This would need a closer look.
Author
There was a problem hiding this comment.
If we would need additional arguments in the future after the current ones it would be nice to be able to escape the : in the default value. Would this be an approach to go for?
something like "WEBSITE_URL": "${localEnv:WEBSITE_URL:https\://example.com"
fix limitting parts of variable substitution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to use a default value like this: