Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and lint on .travis.yml #6 #7

Merged
merged 2 commits into from
Sep 7, 2019
Merged

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Sep 5, 2019

#6
I setup travis-ci including go vet, golint, go build, go test -v ./...

@devdinu
Copy link
Owner

devdinu commented Sep 6, 2019

@u5surf Could you enable travis CI for your fork, so we could verify and can merge right away. (CI build link didn't show up) Nice thing would be to have the CI markdown added in readme.

Thanks for the PR. 🎉

@u5surf
Copy link
Contributor Author

u5surf commented Sep 6, 2019

@devdinu
Thanks for reviewing
I did the repos which I forked yours.
https://travis-ci.com/u5surf/gcloud-client/builds/126012851

Could you activate your travis account? Let's try it following pages!
https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci

@devdinu devdinu merged commit 1753fa5 into devdinu:master Sep 7, 2019
@devdinu
Copy link
Owner

devdinu commented Sep 7, 2019

The markdown link is [![Build Status](https://travis-ci.org/devdinu/gcloud-client.svg?branch=master)](https://travis-ci.org/devdinu/gcloud-client) we could update in further commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants