feat: Add antimeridian crossing support to RasterReprojector#269
Open
espg wants to merge 2 commits intodevelopmentseed:mainfrom
Open
feat: Add antimeridian crossing support to RasterReprojector#269espg wants to merge 2 commits intodevelopmentseed:mainfrom
espg wants to merge 2 commits intodevelopmentseed:mainfrom
Conversation
Detect when a tile's output positions span the ±180° meridian and normalize longitudes to a continuous range (e.g., [170, 190] instead of [170, -170]). This prevents mesh triangles from spanning 340° of longitude and ensures correct GPU-side interpolation for tiles near the date line.
1 task
3 tasks
|
I'm curious as to how this works. In |
Member
|
@espg do you think you'd be able to add some visual screenshots/screencasts to your PRs to more visually explain the internals of the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from #266. Needed for default globe discussed on source-cooperative/source.coop#230.
Summary
RasterReprojector— when a tile's WGS84 longitudes span >180°, normalize them to a continuous range (e.g., [170, 190] instead of [170, -170]) so mesh triangles don't wrap the wrong way around the globeCloses #171
Test plan
pnpm testinraster-reproject)cog-basicexample — verify no regression in standard rendering