Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API.md #1

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Create API.md #1

merged 5 commits into from
Feb 6, 2024

Conversation

abarciauskas-bgse
Copy link
Contributor

This will eventually, I would assume, go in swagger documentation but I thought having it in markdown would be helpful now to get alignment on the specification.

docs/src/API.md Outdated

## Endpoint Description

`GET /tiles/{x}/{y}/{z}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abarciauskas-bgse I think we should try to follow the OGC specification here and use something like

GET /collections/{collection_id}/tiles/{x}/{y}/{z}

we will also add

GET /collections/
GET /collections/{collection_id}

@abarciauskas-bgse
Copy link
Contributor Author

@vincentsarago updated to point to the OGC Tiles spec and a few additional notes on the parameters. Let me know if you agree.

@abarciauskas-bgse
Copy link
Contributor Author

@vincentsarago do you think this documentation is useful or should I close this PR?

@vincentsarago
Copy link
Member

@abarciauskas-bgse this documentation will be really useful but I think we should wait for the API to be finish or at least in a better state

@abarciauskas-bgse abarciauskas-bgse marked this pull request as draft January 22, 2024 16:41
@vincentsarago vincentsarago changed the base branch from main to develop February 6, 2024 14:36
@vincentsarago vincentsarago marked this pull request as ready for review February 6, 2024 15:35
@abarciauskas-bgse abarciauskas-bgse merged commit 21af226 into develop Feb 6, 2024
5 checks passed
@abarciauskas-bgse abarciauskas-bgse deleted the ab/initial-api-spec branch February 6, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants