-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow file separated band storage #19
Conversation
title="Band names", | ||
description="Band names.", | ||
), | ||
] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bands=B04&bands=B03&bands=B02
title="Regex expression to parse dataset links", | ||
description="Regex expression to parse dataset links.", | ||
), | ||
] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bands_regex="B[0-9][0-9]"
"provider": r["meta"]["provider-id"], | ||
} | ||
) | ||
if bands_regex: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago This looks good to me. In the future we may want consider a more explicit mapping of band id->band regex. Something like bands_regex=.*B10\.tif.*&bands_regex=.*B09\.tif.*
so that we are only linking the same assets listed in the bands parameter but I think the approach you have here should be good until we find a dataset that breaks it :]
closes #18
In the endpoints this PR add two new options:
B01
key to use to specify thefile
urlB[0-9][0-9]
, regex expression to use to find theband
name in the URLcc @sharkinsspatial