Fix release type for github workflows, switch to new auth #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_dispatch:
allows us to start the workflow manually in case something fails.Type
published
fires only when actually publishing the release.create
also fires when draft is created/saved, so when you upload files to the release, it will automatically save it as draft. For security reasons, GitHub doesn't start workflow whencreate
event is fired, if it doesn't also publish the release at the same time.This can seemingly work in some repositories where no additional files are uploaded when doing the release, but that's not the case here.
https://docs.github.com/en/webhooks/webhook-events-and-payloads#release
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#release
From GitHub docs:
PR also removes the password field as PyPi uses new auth methods.