Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating sources for RHEL10. #155

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

phracek
Copy link
Collaborator

@phracek phracek commented Jan 10, 2025

Add support for generating sources for RHEL10

Added distconf/rhel-10-x86_64 configuration file.
Add rhel10 to tests/minimal-dockerfile files

Added distconf/rhel-10-x86_64 configuration file.
Add rhel10 to tests/minimal-dockerfile files

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Collaborator Author

phracek commented Jan 10, 2025

@praiskup @SlouchyButton Can you please review it as soon as you have free time? Thanks.

@phracek
Copy link
Collaborator Author

phracek commented Jan 10, 2025

RPM build failures:

Start: buildsrpm
Start: rpmbuild -bs
sh: /usr/bin/python3.6: No such file or directory
sh: /usr/bin/python3.6: No such file or directory
Building target platforms: x86_64
Building for target x86_64

Copy link
Member

@SlouchyButton SlouchyButton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version in pyproject.toml.

EPEL build failure is expected, it shouldn't be enabled (it stayed enabled for PRs for some reason).

If, for some reason, this change is required in EPEL8 and 9, then this will have to be ported to the legacy branch, which is used for EPEL build due to outdated Python. PyPi distributed version will work everywhere as long as the python version dependency from pyproject.toml is met.

tests/minimal-dockerfile/test.exp Show resolved Hide resolved
@SlouchyButton
Copy link
Member

RPM build failures:

Start: buildsrpm
Start: rpmbuild -bs
sh: /usr/bin/python3.6: No such file or directory
sh: /usr/bin/python3.6: No such file or directory
Building target platforms: x86_64
Building for target x86_64

Where did you get this error? From workflow logs I see fedora passed and epels failed with different reasons.

Add more spaces to 'tests/minimal-dockerfile/test.exp'

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Collaborator Author

phracek commented Jan 14, 2025

RPM build failures:

Start: buildsrpm
Start: rpmbuild -bs
sh: /usr/bin/python3.6: No such file or directory
sh: /usr/bin/python3.6: No such file or directory
Building target platforms: x86_64
Building for target x86_64

Where did you get this error? From workflow logs I see fedora passed and epels failed with different reasons.

From Copr builds.

Copy link
Member

@SlouchyButton SlouchyButton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Copr builds.

I see that Fedora passed, so I think we good. Merging, thanks a lot for the changes. Will make a release.

@SlouchyButton SlouchyButton merged commit 69531e6 into main Jan 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants