Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardized and updated tests #180

Merged
merged 2 commits into from
Sep 11, 2024
Merged

refactor: standardized and updated tests #180

merged 2 commits into from
Sep 11, 2024

Conversation

Frompaje
Copy link
Contributor

@Frompaje Frompaje commented Aug 27, 2024

Closes #174
account
image

image

image
social-media
image

twitter
image
não foi alterado nada no test. obs:@juliaam ta refazendo esse teste

user
image

Copy link
Contributor

github-actions bot commented Aug 27, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.06% (🎯 85%) 284 / 330
🟢 Statements 86.14% (🎯 85%) 286 / 332
🟢 Functions 85.32% (🎯 85%) 93 / 109
🔴 Branches 79.62% (🎯 85%) 43 / 54
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/shared/test-helpers/mocks/account.mock.ts 100% 100% 100% 100%
Generated in workflow #332

@Frompaje Frompaje requested review from k1nha, zoldyzdk and hxsggsz August 27, 2024 16:02
@Frompaje Frompaje requested review from DominMFD and juliaam September 6, 2024 15:52
@Frompaje Frompaje requested review from a team as code owners September 6, 2024 15:53
@Frompaje Frompaje requested review from Luiginicoletti, JpBurgarelli and PiluVitu and removed request for a team September 6, 2024 15:53
@DominMFD
Copy link
Contributor

DominMFD commented Sep 9, 2024

Adiciona print da UI de testes

Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito pica, quero aprender mais sobre testes, ta mandando muito e eu to aprendendo com teus pr. <3

describe('UserCreateService', () => {
it('should call userRepository with correct params', async () => {
const repositorySpy = vi.spyOn(userRepository, 'create');
describe('UserCreateService', () => {
Copy link
Member

@k1nha k1nha Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundante, esse describe seria pra que? o describe pai já sintetiza o bloco de teste

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não tinha percebido na hora, valeu

@Frompaje Frompaje requested a review from k1nha September 10, 2024 11:16
@PiluVitu PiluVitu merged commit c260f3e into main Sep 11, 2024
3 of 4 checks passed
@PiluVitu PiluVitu deleted the refac/test branch September 11, 2024 15:55
@Frompaje Frompaje mentioned this pull request Sep 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[test] - refactor and standardize tests
6 participants