Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 175 - post twitter #182

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Issue 175 - post twitter #182

wants to merge 2 commits into from

Conversation

juliaam
Copy link
Contributor

@juliaam juliaam commented Sep 2, 2024

Closes

Feature

Essa tarefa é responsável por fazer o endpoint do post do twitter, com as partes anteriores de autenticação já feitas

Checklist
  • Issue linked
  • Build working correctly
  • Tests created
Additional info

@juliaam juliaam requested review from a team as code owners September 2, 2024 18:08
@juliaam juliaam requested review from Luiginicoletti, JpBurgarelli, PiluVitu, Frompaje and DominMFD and removed request for a team September 2, 2024 18:08
@juliaam juliaam marked this pull request as draft September 2, 2024 18:09
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 82.55% (🎯 85%) 284 / 344
🔴 Statements 82.65% (🎯 85%) 286 / 346
🔴 Functions 83.03% (🎯 85%) 93 / 112
🔴 Branches 79.62% (🎯 85%) 43 / 54
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/features/twitter/controllers/twitter-controller.ts 57.89% 50% 75% 57.89% 31, 33, 35, 37, 41, 43, 45, 47
src/features/twitter/services/post-twitter-service.ts 0% 100% 0% 0% 14-15, 19-32, 20-26, 28, 30-31
Generated in workflow #319

Copy link
Contributor

@melo-zip melo-zip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que é uma boa mudar os imports pra manter o padrão utilizando alias

Comment on lines 8 to +10
import { generateAuthURL } from '../helpers/generate-auth-url';
import type { AuthorizeTwitterService } from '../services/authorize-twitter-service';
import type { PostTwitterService } from '../services/post-twitter-service';
Copy link
Contributor

@melo-zip melo-zip Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { generateAuthURL } from '../helpers/generate-auth-url';
import type { AuthorizeTwitterService } from '../services/authorize-twitter-service';
import type { PostTwitterService } from '../services/post-twitter-service';
import { generateAuthURL } from '@/features/twitter/helpers/generate-auth-url';
import type { AuthorizeTwitterService } from '@/features/twitter/services/authorize-twitter-service';
import type { PostTwitterService } from '@/features/twitter/services/post-twitter-service';

Comment on lines 7 to 10
import { TwitterController } from '../controllers/twitter-controller';
import { AuthorizeTwitterService } from '../services/authorize-twitter-service';
import { PostTwitterService } from '../services/post-twitter-service';
import { TwitterService } from '../services/twitter-service';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { TwitterController } from '../controllers/twitter-controller';
import { AuthorizeTwitterService } from '../services/authorize-twitter-service';
import { PostTwitterService } from '../services/post-twitter-service';
import { TwitterService } from '../services/twitter-service';
import { TwitterController } from '@/features/twitter/controllers/twitter-controller';
import { AuthorizeTwitterService } from '@/features/twitter/services/authorize-twitter-service';
import { PostTwitterService } from '@/features/twitter/services/post-twitter-service';
import { TwitterService } from '@/features/twitter/services/twitter-service';

import type { Logger } from '@/shared/infra/logger/logger';
import type { Service } from '@/shared/protocols/service';

import type { TwitterPostResponse } from '../models/twitter-models';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import type { TwitterPostResponse } from '../models/twitter-models';
import type { TwitterPostResponse } from '@/features/twitter/models/twitter-models';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants