Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: login twitter test #187

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: login twitter test #187

wants to merge 11 commits into from

Conversation

juliaam
Copy link
Contributor

@juliaam juliaam commented Sep 4, 2024

Closes #183

Feature

Criação do teste para o login do twitter

Visual evidences 🖼️

image

Checklist
  • Issue linked
  • Build working correctly
  • Tests created

@juliaam juliaam requested review from a team as code owners September 4, 2024 21:11
@juliaam juliaam requested review from Luiginicoletti, JpBurgarelli, PiluVitu, Frompaje and DominMFD and removed request for a team September 4, 2024 21:11
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 88.44% (🎯 85%) 291 / 329
🟢 Statements 88.51% (🎯 85%) 293 / 331
🟢 Functions 86.23% (🎯 85%) 94 / 109
🔴 Branches 81.48% (🎯 85%) 44 / 54
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/middlewares/auth/auth-jwt.ts 100% 100% 100% 100%
Generated in workflow #343

@DominMFD DominMFD self-assigned this Sep 5, 2024
Copy link
Contributor

@Frompaje Frompaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tem que padronizar esse arquivo todo pra ficar igual os teste da pr #174

@DominMFD DominMFD assigned juliaam and unassigned DominMFD Sep 9, 2024
DominMFD
DominMFD previously approved these changes Sep 9, 2024
@DominMFD
Copy link
Contributor

DominMFD commented Sep 9, 2024

Amiga, tira um print da UI de teste mostrando os coverage

Luiginicoletti
Luiginicoletti previously approved these changes Sep 10, 2024
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amassou como sempre xu!

gif-by-late-night-with-seth-meyers

@k1nha
Copy link
Member

k1nha commented Sep 10, 2024

esses testes não deveriam ser feitos depois da refatoração no controller e service do twitter?

@Frompaje Frompaje self-requested a review September 12, 2024 16:46

vi.spyOn(jwt, 'verify').mockReturnValue(mockPayload as any);

authController.login(req, res, next);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq ta sem await?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq nao precisa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mas nao sei se é melhor com ou sem btw

@juliaam juliaam marked this pull request as draft September 20, 2024 16:15
@juliaam juliaam dismissed stale reviews from Luiginicoletti and DominMFD via 444cec0 September 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] Criar Teste para Componentes de Autenticação
5 participants