Corrigido o estilo do sidebar. #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaam
requested changes
Aug 22, 2024
|
|
DominMFD
requested changes
Aug 26, 2024
JpBurgarelli
suggested changes
Aug 26, 2024
juliaam
requested changes
Aug 27, 2024
juliaam
requested review from
Luiginicoletti,
JpBurgarelli,
juliaam,
PiluVitu,
Frompaje and
DominMFD
DominMFD
approved these changes
Aug 29, 2024
Alecell
reviewed
Aug 30, 2024
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.module.scss
Outdated
Show resolved
Hide resolved
Alecell
reviewed
Aug 30, 2024
src/pages/home/components/Sidebar/components/SocialAccordion/SocialAccordion.module.scss
Outdated
Show resolved
Hide resolved
Alecell
suggested changes
Aug 30, 2024
|
Cade a thread? |
JpBurgarelli
suggested changes
Aug 30, 2024
wendesongomes
force-pushed
the
refactorStyleSidebar#591
branch
from
35bf777 to
8169b4f
Compare
Alecell
suggested changes
Sep 4, 2024
| const socialMediaName = socialMedias | ||
| .get(props.socialMediaId) | ||
| ?.name.toLowerCase(); | ||
| const iconPath = iconMap[socialMediaName as keyof typeof iconMap]; |
There was a problem hiding this comment.
as keyof typeof vou morrer. Pq precisamos disso?
juliaam
requested changes
Sep 4, 2024
| @@ -84,55 +84,55 @@ | |||
| "userName": "Discord User 1", | |||
| "token": "DISCORD_EXAMPLE_TOKEN_1", | |||
| "valid": true, | |||
| "avatar": "https://example.com/image1.jpg" | |||
| "avatar": "https://cdn0.iconfinder.com/data/icons/free-social-media-set/24/discord-256.png" | |||
There was a problem hiding this comment.
é pra usar o ícone de um arquivo local do projeto, vamos conversar sobre
There was a problem hiding this comment.
e o ícone também não tá condizente com o do figma
Comment on lines
+3
to
+6
| .username { | ||
| margin: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
muito bom! deixou alinhadinho ao layout!
There was a problem hiding this comment.
isso não deve ficar aqui, todos os icons estão em src/components/Icons/icons, e já tem o do discord
| @@ -45,11 +48,26 @@ function SocialAccordion(props: SocialAccordionProps): ReactNode { | |||
| )); | |||
|
|
|||
| const renderAccordionContent = (): ReactNode => ( | |||
| <ul role="listitem">{renderAccordionMap()}</ul> | |||
| <ul className={scss.containerAccordion} role="listitem"> | |||
| {renderAccordionMap()} | |||
There was a problem hiding this comment.
não é mais assim no code-style atual, tem que colocar no .components
JpBurgarelli
suggested changes
Sep 4, 2024
juliaam
removed
AGUARDANDO ALE
Changes Requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #591
Feature
Este PR corrige o problema onde o estilo da sidebar havia sido pedido, retornando-a ao seu design padrão. Após algumas modificações, o estilo original foi perdido, e esta atualização restaura o layout e a aparência esperados para garantir consistência na interface do usuário.
Visual evidences 🖼️