This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Migration to query dsl 4 #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .where(privateRepository.owner.netId.equalsIgnoreCase(username) | ||
| .and(privateRepository.title.equalsIgnoreCase(repositoryTitle))) | ||
| .singleResult(privateRepository), | ||
| .fetchOne(), |
There was a problem hiding this comment.
If fetchOne fails fast, then the ensureNotNull wrapper is unnecessary. But throughout Devhub we always propagate EntityNotFound exceptions, so if fetchOne throws something else, we should always catch and rethrow it, or may break other logic.
There was a problem hiding this comment.
If there is no result it still returns null, leaving that logic valid, however it is stricter in the sense that for this query would there be two values, it throws a Not-unique exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querydsl moved to a new domain and has a new version out.
The main issue is that
.exists(); is gone in the newer version
The closest I could translate this is:
.fetchCount() > 0;
I opted for the fail fast FetchOne instead of FetchFirst, but this is debatable.
Further more map is no longer supported since they didn't like the usage of it and has become a group by.